Skip to content
Snippets Groups Projects

Switched from hard-coded parameters to YAML-based parameters for BMON unpacker in cbm::algo.

Merged Dominik Smith requested to merge d.smith/cbmroot:BmonYamlParSubmit into master
All threads resolved!

Feature requested in https://redmine.cbm.gsi.de/issues/3323.

Works together with changes from CbmSoft/cbmroot_parameter!190 (merged).

An automated test was run, which verified that the number of produced BMON digis matches for all three cases (mcbm2022, mcbm2024) between the master and new versions. The reviewer is invited to carry out additional tests.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 2 commits

    • 8cf2679c - Switched from hard-coded parameters to YAML-based parameters for TOF unpacker in cbm::algo.
    • b3168665 - Bump parameters hash to bring new BMON online unpacker par files

    Compare with previous version

  • Pierre-Alain Loizeau approved this merge request

    approved this merge request

  • added 3 commits

    • b42c3023 - 1 commit from branch computing:master
    • 729a5b6f - Switched from hard-coded parameters to YAML-based parameters for TOF unpacker in cbm::algo.
    • a70f3389 - Bump parameters hash to bring new BMON online unpacker par files

    Compare with previous version

  • Pierre-Alain Loizeau resolved all threads

    resolved all threads

  • Pierre-Alain Loizeau enabled an automatic merge when the pipeline for a70f3389 succeeds

    enabled an automatic merge when the pipeline for a70f3389 succeeds

  • Dear @d.smith, @fweig, @f.uhlig, @v.friese, @p.-a.loizeau,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • Please register or sign in to reply
    Loading