Skip to content
Snippets Groups Projects

Switched from hard-coded parameters to YAML-based parameters for TOF unpacker in cbm::algo.

Merged Dominik Smith requested to merge d.smith/cbmroot:TofYamlParSubmit into master
All threads resolved!

Feature requested in https://redmine.cbm.gsi.de/issues/3323.

Works together with changes from CbmSoft/cbmroot_parameter!189 (merged).

An automated test was run, which verified that the number of produced TOF digis matches for all three cases (mcbm2022, mcbm2024, mcbm2024_05) between the master and new versions. The reviewer is invited to carry out additional tests.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dominik Smith added 6 commits

    added 6 commits

    • 0a24fbd3...4596383a - 5 commits from branch computing:master
    • 010cf428 - Switched from hard-coded parameters to YAML-based parameters for TOF unpacker in cbm::algo.

    Compare with previous version

  • Dominik Smith resolved all threads

    resolved all threads

  • Dominik Smith enabled an automatic merge when the pipeline for 010cf428 succeeds

    enabled an automatic merge when the pipeline for 010cf428 succeeds

  • added 1 commit

    • 4f075fca - Bump parameters hash to bring new TOF online unpacker par files

    Compare with previous version

  • Pierre-Alain Loizeau enabled an automatic merge when the pipeline for 4f075fca succeeds

    enabled an automatic merge when the pipeline for 4f075fca succeeds

  • Pierre-Alain Loizeau approved this merge request

    approved this merge request

  • Dear @d.smith, @fweig, @n.herrmann, @i.deppner, @f.uhlig, @v.friese, @p.-a.loizeau,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • Dominik Smith resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading