Switched from hard-coded parameters to YAML-based parameters for TOF unpacker in cbm::algo.
Feature requested in https://redmine.cbm.gsi.de/issues/3323.
Works together with changes from CbmSoft/cbmroot_parameter!189 (merged).
An automated test was run, which verified that the number of produced TOF digis matches for all three cases (mcbm2022, mcbm2024, mcbm2024_05) between the master and new versions. The reviewer is invited to carry out additional tests.
Merge request reports
Activity
requested review from @p.-a.loizeau
assigned to @fweig
- Resolved by Pierre-Alain Loizeau
- Resolved by Dominik Smith
@p.-a.loizeau Pipeline fails because the parameters from CbmSoft/cbmroot_parameter!189 (merged) are needed.
added 6 commits
-
0a24fbd3...4596383a - 5 commits from branch
computing:master
- 010cf428 - Switched from hard-coded parameters to YAML-based parameters for TOF unpacker in cbm::algo.
-
0a24fbd3...4596383a - 5 commits from branch
enabled an automatic merge when the pipeline for 010cf428 succeeds
added Online Parameters labels
- Resolved by Dominik Smith
@d.smith I think you forgot the hash update
https://cdash.gsi.de/testDetails.php?test=20617506&build=460376
mentioned in merge request CbmSoft/cbmroot_parameter!190 (merged)
added 1 commit
- 4f075fca - Bump parameters hash to bring new TOF online unpacker par files
enabled an automatic merge when the pipeline for 4f075fca succeeds
Dear @d.smith, @fweig, @n.herrmann, @i.deppner, @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label