external: Add poolSTL as alternative for parallel sorting.

i have the problem that the poolstl headers are not found when using CbmRoot only with the installation directory without having access to the src and build directory. I get the following error:

In file included from libCbmRecoTasks dictionary payload:126:
In file included from /lustre/cbm/users/apuntke/beamtime/apuntke-cbmroot-master/inst/include/CbmTaskUnpack.h:24:
In file included from /lustre/cbm/users/apuntke/beamtime/apuntke-cbmroot-master/inst/include/bmon/Unpack.h:7:
In file included from /lustre/cbm/users/apuntke/beamtime/apuntke-cbmroot-master/inst/include/CommonUnpacker.h:10:
/lustre/cbm/users/apuntke/beamtime/apuntke-cbmroot-master/inst/include/compat/Algorithm.h:21:10: fatal error: 'poolstl/algorithm' file not found
#include <poolstl/algorithm>

The poolstl headers are not copied to the installation directory as it is the case for other external libraries. Could you fix this?

Probably of interest to @f.uhlig as Felix is less available with writing his thesis

@apuntke Shouldn't this be caught by by one of the CI or Weekly tests? or is it happening with a macro/binary which is not covered by them?

PS: I guess that we can discuss it here as we have the full context, we can always also create a redmine issue if needed

Hi Pierre,

I am experiencing the problem when I try to run the macro ${INSTALL_DIR}/${CBMROOT_VER}/inst/share/cbmroot/macro/run/run_inspect_digi_timeslice.C after using the new online unpacker. I compile cbmroot in my home directory and then copy the installation directory to lustre using a python script which copies in 128 threads (because lustre is optimized for highly parallel access) and restarts the copy of each file after 10 s if it does not succeed, because in the last days lustre was very slow in the last days. This method speeds the process up drastically.

I also needed to add some headers in algo/CMakeLists.txt and adjust some include directories in some header files to get it running, I plan to create a merge request for this.

Also manually downloading the poolstl header files from https://github.com/alugowski/poolSTL/tree/main and copying them to {INSTALL_DIR}/${CBMROOT_VER}/inst/include is necessary to get it running.

I am currently working on a solution.

Huuum, I thought that we had one runner testing the installation, but could it be that it just checks that the installation runs through without executing/loading anything?

@p.-a.loizeau,

we only test some of the macros from the installation not all of them.

@apuntke,

could you please check if the change in !1914 (merged) solves your problem.

Hi Florian, thanks for the very quick fix, this solves the problem. Best regards Axel

I also created a merge request with the other changes I needed to do to get the macro running: !1915 (merged)

mentioned in merge request !1914 (merged)

external: Add poolSTL as alternative for parallel sorting.

Merge request reports

Activity