Unpack parameter update for Tof Bucharest counter and new BMon detector in 2024 data
All threads resolved!
- add new treatment of Bucharest counter data unpacking in legacy upacking, by NH
- Port same to algo, by PAL
- Add new BMon to algo, by PAL
Edited by Pierre-Alain Loizeau
Merge request reports
Activity
Dear @n.herrmann, @i.deppner,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
assigned to @p.-a.loizeau
requested review from @d.smith
fine by me.
@d.smith Do you want the corresponding changes to
algo/detectors/tof/ReadoutConfig.cxx
in the same MR or should it be a second one done by you?- Resolved by Pierre-Alain Loizeau
@p.-a.loizeau is this backwards compatible with old data? If so, please go ahead and apply the changes in this MR.
added Parameters mCBM labels
added 13 commits
-
193e39d7...e6225729 - 9 commits from branch
computing:master
- f61a15b9 - [mCBM] In CbmMcbm2018TofPar, update for Tof Bucharest counter in 2024 data
- 5a891384 - [mCBM 2024] in TOF legacy mapping par, change type of Buc box
- 00fe9a0b - Port TOF mapping changes to the algo version
- 86f8b7c1 - Introduce mapping for the new sCVD `bmon` on the `algo` side
Toggle commit list-
193e39d7...e6225729 - 9 commits from branch
I added three commits
- 1st one is backporting the TOF changes to
algo
- porting the changes of @n.herrmann to the algo side
- add also some debug logs to allow checks of the mapping (should be neutral as cost paid only at init)
- changing the type of the last RPC in
ReadoutPars_mCBM2024.cxx
=> checked for run `2391` with the online binary = does not change the mapping \ => checked for run `2906` with the online binary = does change the mapping for the last block
- 2nd one fix the mapping par file for the old unpacker
- 3rd one is introducing mapping for the new sCVD
bmon
on thealgo
side- introducing a
ReadoutPars
struct similar to the one used ontof
to add support for multiple unpack configs - add new detector as "fake" back-side of the existing diamond detector to avoid need a new geometry
- switching readout parameters based on run ID, switch point hard-coded to run
2941
of 02/05/2024
=> checked for run `2391` with the online binary = does not change the mapping \ => checked for run `2906` with the online binary = does not change the mapping \ => checked for run `2942` with the online binary = adds new diamond as "vertical side" of BMon in the mapping \
- introducing a
I checked that with this the online binary can run on
-
2391
,2906
and2942
for BMON -
2391
and2906
for TOF (still missing someEqId
for run2942
)
- 1st one is backporting the TOF changes to
enabled an automatic merge when the pipeline for 86f8b7c1 succeeds
added Online label
Please register or sign in to reply