mRich: DenoiseCNN for mRICH using ONNX Runtime
This MR requires a parameter file from CbmSoft/cbmroot_parameter!177 (merged)
This merge request provides the implementation of a CNN for denoising mRICH hits,
specifically for hits inside ring structures and random noise, which simplifies the ring finding using the Hough ringfinder.
In case CbmEvents
are found, denoising is only running on found events, otherwise on full timeslices.
Since ONNX Runtime is a optional package in FairSoft, it is checked whether ONNX Runtime is installed.
In case it is not found, the corresponding code is not compiled.
For more information see issue #2972
Merge request reports
Activity
added Parameters QA Reconstruction mCBM labels
assigned to @f.uhlig
mentioned in merge request CbmSoft/cbmroot_parameter!177 (merged)
- Resolved by Martin Beyer
- Resolved by Florian Uhlig
- Resolved by Florian Uhlig
@f.uhlig From what I can see in the build summarys, ONNX Runtime is not found. As of FairSoft nov22 ONNX Runtime is available as an optional package, so I guess for the CI FairSoft (nov22+) installations this wasn't installed.
Edited by Martin Beyer
added 15 commits
-
a131d148...e6225729 - 10 commits from branch
computing:master
- 53bae867 - mRich: implementation of the DenoiseNN using a CNN
- 547afeec - [temp] load private branch to test the MR in CI until parameter repo accepts the MR
- 0e3df76a - [temp] set denoiseNN to true for CI testing. Default will probably be false
- 42988b3f - missing DigiMapManager header fix
- 2a46afa9 - comment new flag CbmRichHit.fIsNoiseNN
Toggle commit list-
a131d148...e6225729 - 10 commits from branch
Dear @f.uhlig, @v.friese, @p.-a.loizeau, @ma.beyer,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Martin Beyer
could you please rebase locally since I am not able to rebase from the webgui.
- Resolved by Florian Uhlig
mentioned in merge request !1840 (merged)
added 60 commits
-
2a46afa9...b3dbb887 - 55 commits from branch
computing:master
- 9765a0a2 - mRich: implementation of the DenoiseNN using a CNN
- 0a5f0f9e - [temp] set denoiseNN to true for CI testing. Default will probably be false
- 0ef90d2a - missing DigiMapManager header fix
- 13005be7 - comment new flag CbmRichHit.fIsNoiseNN
- 562118d7 - edit canvas size of SEDs to have correct aspect ratio of mRich, also add axis titles
Toggle commit list-
2a46afa9...b3dbb887 - 55 commits from branch
added 6 commits
-
f3758325 - 1 commit from branch
computing:master
- 8b6f4d56 - mRich: implementation of the DenoiseNN using a CNN
- 76e51a1f - [temp] set denoiseNN to true for CI testing. Default will probably be false
- 811053b2 - missing DigiMapManager header fix
- fc478599 - comment new flag CbmRichHit.fIsNoiseNN
- 8b12cd16 - edit canvas size of SEDs to have correct aspect ratio of mRich, also add axis titles
Toggle commit list-
f3758325 - 1 commit from branch
enabled an automatic merge when the pipeline for 8b12cd16 succeeds