[online] alternative fix for FEB index at mSTS chan masks import, closer to original

@fweig @a.toia: see email

Should remove the need to change the channel mask parameter file for the 2022 data

added BugFix Online labels

requested review from @fweig

assigned to @p.-a.loizeau

Dear @v.friese,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 3 commits

• d5ec0f01...a7ab5082 - 2 commits from branch computing:master
• 79173df5 - [online] alt fix for FEB index at mSTS chan masks import, closer to original

Compare with previous version

marked this merge request as ready

Feedback from @a.toia:

Hi Pierre

I tested your indexing with a dummy mask and it works correctly, I added a diagram with the mapping address->feb in https://indico.gsi.de/event/19723/contributions/79446/attachments/47233/67658/STS24_anaBeam_23042024.pdf

where you can also compare it to 2022.

In principle I have nothing against. The concern I have is that we introduce variables for the mapping that make the code hard to follow (febId, and now also febBaseIdx). Here they are needed only for the ChannelMask and for the AdcCut. My suggestion is to make these parameter directly mapped from the Address. In this way we avoid any map address->feb. But I think we can do it also later

ciao alberica

So Merging it now, we should keep in mind when introducing flexible AdcCuts that it would be better to user the opportunity to switch to the Address as key

merged

added DC branch label

removed DC branch label

Removing the label as I messed up and targeted the master while thinking I was going to the DC branch