online: Integrate TRD hitfinder.
Changelog:
- Integrate TRD hitfinder into online chain
- Adjusted TRD hit to adhere to tracking interface
- Added serialization for trd hits
TODO:
-
Upstream TRD parameter files and bump parameter hash -
Ensure TRD hits are sorted by time -
Fix FASP-flag in TRD2D digis
Edited by Felix Weiglhofer
Merge request reports
Activity
Filter activity
requested review from @d.smith
assigned to @fweig
Looks good.
Two side remarks:
- The optimizations of the TRD hitfinders require the time order of digis to be respected module-wise. I think this is preserved here, so no issues from that side.
- At some point we should get rid of the "trd2d" namespace completely. For the hitfinders the 2D classes are marked with a suffix as discussed, but the unpackers still use separate namespaces. Not to be solved here, but just as a reminder.
- Resolved by Felix Weiglhofer
The class
CbmTaskTrdHitFinderwill need to be adjusted, to use the new interface oftrd::Hit. - Last reply by Felix Weiglhofer
added 19 commits
Toggle commit list- Resolved by Felix Weiglhofer
@d.smith, I've added some debug for the input of the hitfinder (ensures no unknown modules and correct digi types). By default the checks are removed at compile time. (Also fixed the input. I was filling the input vector in the wrong way.
- Last reply by Dominik Smith
mentioned in merge request CbmSoft/cbmroot_parameter!172 (merged)
Please register or sign in to reply