Timing fix for the TRD online unpacker (sys ver 0x10)
Fixes the timing problem I mentioned in yesterdays online meeting @v.friese, @p.-a.loizeau Apart from that the offline and online data was identical, except for some rounding error in the time with a maximum difference of 5ns. Not sure where that comes from.
Merge request reports
Activity
assigned to @p.-a.loizeau
assigned to @fweig and unassigned @p.-a.loizeau
requested review from @d.smith
- Resolved by Pierre-Alain Loizeau
@dschledt Did you check both TRD1D and TRD2D or only TRD1D?
just asking for my list tracking the status of the checks in the unpacked data inspector MR
mentioned in merge request !1742 (merged)
- Resolved by Pierre-Alain Loizeau
@dschledt Do you want to have the hash update from CbmSoft/cbmroot_parameter!170 (merged) in this MR?
or should I put it in a separate MR? (maybe better as this fix applies to both 2022 and 2024 data?)
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 1 commit
- 2ccb6a01 - Update parameter hash to include newest online TRD1D parameters
- Resolved by David Schledt
@dschledt Can you give more details on this rounding error? When does it manifest itself?
added 15 commits
-
2ccb6a01...5cb9f2f5 - 13 commits from branch
computing:master
- 22ce56c1 - Timing fix for the TRD online unpacker (sys ver 0x10)
- 358bf235 - Update parameter hash to include newest online TRD1D parameters
-
2ccb6a01...5cb9f2f5 - 13 commits from branch
added Online label
@dschledt Could you please remove the commit with the change to the hash? I overlooked this MR and did not press for it, and in the meantime other MRs with a hash change pointing to commits above this one were merged (so the parameter fix was silently introduced)
added 31 commits
-
22ce56c1...b4e72d23 - 30 commits from branch
computing:master
- 3d41fe4e - Timing fix for the TRD online unpacker (sys ver 0x10)
-
22ce56c1...b4e72d23 - 30 commits from branch
enabled an automatic merge when the pipeline for 3d41fe4e succeeds