[Online] mSTS 2024 channel masks
MR should have two or three commits when ready:
-
Switch of STS channel mask YAML file based on run ID -
hash update of the parameter repo bringing a mask for mSTS 2024 (empty for now as no channel need masking) -
Not 100% sure: maybe fix to the mixing of channel masks between FEB 8_1
into those ofFEB 8_5
Merge request reports
Activity
added Online Parameters mCBM labels
requested review from @fweig
assigned to @fweig
added 1 commit
- b9b44a59 - [Online] Select STS chan mask files based on run id
added 1 commit
- 267fa1ef - [Online] Select STS chan mask files based on run id
added 1 commit
- 3021a07e - [Online] Select STS chan mask files based on run id
We found the source of the issue in the febId computation: const int32_t febId = feb + compIdx * numCrobPerComp * numFebsPerCrob; This is fully ok for the old feb where numFebsPerCrob is always 5 But for the new FEB8-5 numFebsPerCrob=1, so the FEBs of the new module were mapped in fedId=6 and 7, already existing and used for other modules.
We suggest to change the computation of febId to const int32_t febId = 2 * moduleIdx + moduleSide; We checked that the febId is used only for masking noisy channels and ADC cuts. Is that correct? So we would only need to change the convention of the noisy channel mask (par file) and the ADC cut (not yet a par file, but hardcoded)
Besides that, I have introduced the same convention with the runId fs::path chanMaskFile = 2724 <= Opts().RunId() ? "StsChannelMaskSet_mcbm2024.yaml" : "StsChannelMaskSet_mcbm2022.yaml"; auto chanMask = yaml::ReadFromFilests::ChannelMaskSet(Opts().ParamsDir() / chanMaskFile); sts::ReadoutConfig readout{readoutSetup, chanMask};
I have tested it with a dummy channel mask that was easy to check, and it works fine.
If you agree, we can merge this
added CodeOwners label
assigned to @p.-a.loizeau and unassigned @fweig
Merging after seeing @fweig answer in emails. The fix to the ADC cut is left for another MR in order not to hold the hash update