Add Timeshift per E-Link Functionality for TRD1D Unpacker
This merge request adds the possibility to add time offsets for each E-Link separately in the TRD1D unpacker.
Example Offsets for mCBM2024:
if (runid >= 2700) //mCBM2024
{
for (int elinkId = 0; elinkId < 36; ++elinkId)
{
trd1Dconfig->SetElinkTimeOffset(20736, elinkId, -36);
trd1Dconfig->SetElinkTimeOffset(20737, elinkId, -37);
trd1Dconfig->SetElinkTimeOffset(20738, elinkId, -65);
trd1Dconfig->SetElinkTimeOffset(20739, elinkId, -52);
trd1Dconfig->SetElinkTimeOffset(20740, elinkId, -50);
trd1Dconfig->SetElinkTimeOffset(20741, elinkId, -49);
//trd1Dconfig->SetElinkTimeOffset(20992, elinkId, 0); //no correlation
trd1Dconfig->SetElinkTimeOffset(20993, elinkId, -50);
trd1Dconfig->SetElinkTimeOffset(20994, elinkId, -57);
trd1Dconfig->SetElinkTimeOffset(20995, elinkId, -52);
trd1Dconfig->SetElinkTimeOffset(20996, elinkId, -52);
trd1Dconfig->SetElinkTimeOffset(20997, elinkId, -53);
}
}
Merge request reports
Activity
mentioned in merge request !1741 (merged)
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Alexandru Bercuci
Thx. I will incorporate it in the steering script. !1741 (merged)
@apuntke did you check that the old functionality is still working ? Are the 2022 data still unpack-able ?
Edited by Alexandru Bercuci
Ping @d.smith as this functionality will probably be also needed in the online algo version
added Reconstruction mCBM labels
assigned to @p.-a.loizeau
requested review from @a.bercuci
added 10 commits
-
66847d7c...a253e60c - 8 commits from branch
computing:master
- e7fe0e4a - Integrated E-Link Timeshift Functionality in TRD Unpacker
- 4e706062 - Apply clang-format
-
66847d7c...a253e60c - 8 commits from branch
mentioned in merge request CbmSoft/cbmroot_parameter!165 (merged)
Just a general comment: The online-capable unpacker already supports "per elink" time offsets (see
cbmroot/algo/detectors/trd/UnpackMS.*
). Should be straight-forward to include these settings in the yaml files.@fweig do you have an eye on this?
I've opened an issue to track this: #3261
Thanks for the ping! Might have missed this.
Edited by Felix Weiglhofer
added 4 commits
-
4e706062...682ff512 - 2 commits from branch
computing:master
- bff74bfd - Integrated E-Link Timeshift Functionality in TRD Unpacker
- 4c6ead1d - Apply clang-format
-
4e706062...682ff512 - 2 commits from branch
enabled an automatic merge when the pipeline for 4c6ead1d succeeds