Skip to content
Snippets Groups Projects

Clang format scripts as in MR

Merged Pierre-Alain Loizeau requested to merge p.-a.loizeau/cbmroot:clang_format_scripts into master

Add scripts to check and apply (including commit) same format sequence as in MR

Related to new section in Redmine wiki advising user to set upstream, check changes proposed by clang-format and apply them after doing hand edit where necessary

TO CHECK: The scripts right now check on hard-coded version of clang format 11.0.0

Edited by Pierre-Alain Loizeau

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 6700d5a5 - In clang format apply script, print git commands instead of executing add/commit

    Compare with previous version

    • Resolved by Florian Uhlig

      As discussed you hard code the name of the upstream repository to be upstream. I think you can't rely on this name because the name can be chosen by each user and I know at least one user which have chosen a different name.

      I propose finally to have only one script which has two parameters. The first one is the name of the upstream repository and the second is an option which is either check or apply.

      The name of the repository you can get also by this command which uses the fact that we know the URL of the upstream repository.

      git remote -v | grep https://git.cbm.gsi.de/computing/cbmroot | cut -f1 | uniq

      So I think we need only one parameter for the script. I would put the default one to check

  • added 1 commit

    • ad47383a - Unify check and apply format scripts into single one + auto-detect upstream remote name

    Compare with previous version

  • added 1 commit

    • 9ce95387 - Use UPSTREAM variable in check/apply script

    Compare with previous version

  • added 1 commit

    • bb01b3b2 - Unify detection of upstream remote in https and ssh cases

    Compare with previous version

  • added 1 commit

    • a058276b - In check format scripts, move argument number check to top

    Compare with previous version

  • Florian Uhlig resolved all threads

    resolved all threads

  • Florian Uhlig resolved all threads

    resolved all threads

  • Florian Uhlig resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading