Clang format scripts as in MR
Add scripts to check and apply (including commit) same format sequence as in MR
Related to new section in Redmine wiki advising user to set upstream, check changes proposed by clang-format and apply them after doing hand edit where necessary
TO CHECK: The scripts right now check on hard-coded version of clang format 11.0.0
Merge request reports
Activity
added 7 commits
-
f02f613f...55b769bf - 5 commits from branch
computing:master
- 860d29da - Add scripts to check and apply same format sequence as in MR
- 045124a9 - Add scripts to check and apply same format sequence as in MR
-
f02f613f...55b769bf - 5 commits from branch
added 15 commits
-
045124a9...7f6a2088 - 13 commits from branch
computing:master
- 71e2cc1f - Add scripts to check and apply same format sequence as in MR
- 644d323e - Add scripts to check and apply same format sequence as in MR
-
045124a9...7f6a2088 - 13 commits from branch
added 8 commits
-
644d323e...b24b5a16 - 6 commits from branch
computing:master
- e6e272fc - Add scripts to check and apply same format sequence as in MR
- cb07b3fb - Add scripts to check and apply same format sequence as in MR
-
644d323e...b24b5a16 - 6 commits from branch
added 11 commits
-
cb07b3fb...723791ea - 8 commits from branch
computing:master
- 1229962d - Add scripts to check and apply same format sequence as in MR
- b508904f - Add scripts to check and apply same format sequence as in MR
- c1a7f4f3 - Add check on clang version in check and apply format scripts
Toggle commit list-
cb07b3fb...723791ea - 8 commits from branch
- Resolved by Florian Uhlig
added 1 commit
- 6700d5a5 - In clang format apply script, print git commands instead of executing add/commit
- Resolved by Florian Uhlig
As discussed you hard code the name of the upstream repository to be upstream. I think you can't rely on this name because the name can be chosen by each user and I know at least one user which have chosen a different name.
I propose finally to have only one script which has two parameters. The first one is the name of the upstream repository and the second is an option which is either check or apply.
The name of the repository you can get also by this command which uses the fact that we know the URL of the upstream repository.
git remote -v | grep https://git.cbm.gsi.de/computing/cbmroot | cut -f1 | uniq
So I think we need only one parameter for the script. I would put the default one to check
- Resolved by Pierre-Alain Loizeau
added 1 commit
- ad47383a - Unify check and apply format scripts into single one + auto-detect upstream remote name
- Resolved by Pierre-Alain Loizeau
- Resolved by Pierre-Alain Loizeau
- Resolved by Florian Uhlig
added 1 commit
- bb01b3b2 - Unify detection of upstream remote in https and ssh cases
added 1 commit
- a058276b - In check format scripts, move argument number check to top