Skip to content
Snippets Groups Projects

Draft: Improve CI tests for the mvd detector

Open Florian Uhlig requested to merge f.uhlig/cbmroot:fix_mvd_CI_tests into master
1 unresolved thread

Modify CI tests for the mvd detector

Unify the macros such that it possible to switch between event and timebased mode by a parameter. Add also a test of mixed mode where one has two mc files as input for the digitisation. Add new macro to execute mc matching and a simple analysis to check if the residuals of the positions are okay and also to see if the matching works.

Modify the build system such that all three run modes are tested.

Fix the access of MC information in CbmMvdQa

If not using the MCDataManager the code crashes when running in timebased mode. With the previous code one did not access the data at the correct entry but always for enty 0 which is wrong in best case ends in a crash to to a out-of-bounds access.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Uhlig added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Uhlig added 1 commit

    added 1 commit

    Compare with previous version

  • Florian Uhlig resolved all threads

    resolved all threads

  • Florian Uhlig added 7 commits

    added 7 commits

    Compare with previous version

  • Dear @c.muentz, @m.deveaux,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

    • That look ok, but I have a basic question: You introduce the MCDataManager and its usage (fMvdPoints) in the method ExecHitQa(), but it is kind of in parallel to the "old style" MCPointArray (fMcPoints). The latter continues to be used in other methods. Is is intended so, and if yes, why?

  • Florian Uhlig marked this merge request as draft

    marked this merge request as draft

  • Florian Uhlig added 310 commits

    added 310 commits

    Compare with previous version

  • added 43 commits

    Compare with previous version

  • Pierre-Alain Loizeau mentioned in merge request !1890 (merged)

    mentioned in merge request !1890 (merged)

  • added 321 commits

    Compare with previous version

  • Florian Uhlig added 20 commits

    added 20 commits

    Compare with previous version

  • Florian Uhlig added 79 commits

    added 79 commits

    Compare with previous version

  • added 44 commits

    Compare with previous version

  • Florian Uhlig added 34 commits

    added 34 commits

    Compare with previous version

  • Please register or sign in to reply
    Loading