Lit: Remove Bremsstrahlung energy loss for electrons and replace with existing Bethe Bloch for electrons #3019
- The Lit extrapolator was using Bremsstrahlung for the energy loss calculation in case of electrons, which resulted in wrong momentum updates and therefore wrong extrapolations (see issue #3019)
- Replaced with BetheBloch energy loss specialized for electrons/positrons which was already implemented, the energy loss depends on charge which needs to be checked since such charge dependent asymmetry is not observed in geant3. Also is is to large by a factor of 2 when comparing with geant3.
- Other extrapolations by the LitExtrapolator were correct, since muon or pion particle hypothesis are used, where the energy loss is not calculated via Bremsstrahlung (full bethe bloch instead)
Merge request reports
Activity
changed milestone to %OCT23
added Reconstruction label
requested review from @se.gorbunov
Dear @s.lebedev, @andrey.lebedev,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Sergey Gorbunov
-
Florian asked us to separate the code formatting from the code changes. It makes sense to split your commit into two: the first one with the clang format and the second one with the code changes. Or vise versa.
-
Why is it marked as Draft? Are you waiting for a review from Semen? For me, it looks fine, so I'll make him a reviewer.
-
assigned to @se.gorbunov
requested review from @s.lebedev and removed review request for @se.gorbunov
requested review from @se.gorbunov and removed review request for @s.lebedev