Rich: update macro/rich/run macros to be compilable and update batch scripts (remove hardcoded paths)
Few small changes:
- add "defined(_ _ ROOTCLING _ _)" to macros to make them compileable (for running them with a debugger)
- use __ FILE __ to create default output files paths relative to the macro location, i.e. for calling macros from a different directory or in my case the debugger
- remove hardcoded paths from batch scripts
Merge request reports
Activity
@e.clerkin Thanks for the comment on hardcoded user paths, I simply adapted from existing code.
Now 6 hardcoded paths out of hundreds in the repo are removed .mentioned in merge request !1369 (merged)
Dear @ma.beyer,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
thanks for taking action so fast. As I said in the meeting I am not so much concerned about code in more private directories like macro/rich but I also agree with @e.clerkin that it is better not to have them in.
added 4 commits
-
d3cf5be1...6ee18977 - 3 commits from branch
computing:master
- 65769151 - update macros to be compileable and update batch scripts
-
d3cf5be1...6ee18977 - 3 commits from branch
changed milestone to %OCT23
added BugFix label
enabled an automatic merge when the pipeline for 65769151 succeeds