Set webgui browser off by default
via alias. Addresses recent cern root issue.
Possibly option for a solution.
As introduced by @f.uhlig in today's software and discussed by @p.-a.loizeau and @m.shiroya
Merge request reports
Activity
requested review from @p.-a.loizeau
assigned to @f.uhlig
Dear @f.uhlig,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 2 commits
added 2 commits
added BugFix Build System labels
changed milestone to %OCT23
added 3 commits
-
5fe600c8...6ee18977 - 2 commits from branch
computing:master - a79520cd - Set webgui browser off by default
-
5fe600c8...6ee18977 - 2 commits from branch
- Resolved by Florian Uhlig
Did someone test the changes?
- Last reply by Florian Uhlig
- Resolved by Pierre-Alain Loizeau
Although most of us, including me, have never really used the web based TBrowser, some of our cbmroot user-base may, and removing this may annoy them.
Therefore, I think we should inform them how to disable the alias if they want, and perhaps this can be but as a flagged option of the config.
Depending on how serious this security flaw is, I think this should be addressed by us and can be via a commit like this.
@f.uhlig I would ask that you do this in addition at the FairRoot level. Two aliases will just overwrite each other.
- Last reply by Pierre-Alain Loizeau
added 3 commits
-
a79520cd...58ff3bd1 - 2 commits from branch
computing:master - 78e1f39a - Set webgui browser off by default
-
a79520cd...58ff3bd1 - 2 commits from branch
enabled an automatic merge when the pipeline for 78e1f39a succeeds
