add support for the new geometry format
The current code integrates a new geometry format support for the TRD system.
Context
-
Following the approval of the TDR Addendum for the TRD the inner part of the TRD wall will be operated with TRD2D detectors. - A new geometry (construction/usage) concept for the TRD geometry was proposed:
- According to the verbal understanding from https://indico.gsi.de/event/18650/ the following strategy was assumed
- The geometry will be accepted without [running/standard] Creation macro
- The code has to work with TRD implementation as is provided in the binary file from geometry (trd_v23b_1[e,h,m].geo.root)
- The implementation details from !1382 (merged) will be left for after the Release in order to not destabilize the system
- Deadline for this MR is next Release of 2023 (be it OCT23 or other name)
- The current MR describe only the code. In order to use the TRD2D the following actions have still to be performed:
-
Accept MR CbmSoft/cbmroot_geometry!224 (merged) (done by Eoin) -
Accept MR CbmSoft/cbmroot_parameter!147 (merged) (done by Eoin) -
Update the following files (geometry/setup/setup_sis100_electron.C, external/InstallGeometry.cmake, external/InstallParameter.cmake) (Built upon and test passed in !1552 (closed) )
Merge request reports
Activity
changed milestone to %OCT23
added Geometry Reconstruction Simulation TRD2D labels
requested review from @f.uhlig
assigned to @a.bercuci
mentioned in merge request !1382 (merged)
mentioned in merge request CbmSoft/cbmroot_parameter!147 (merged)
In the attention of @e.clerkin and @d.emschermann
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
thanks for the changes. I will have a look at the code hopefully later today. I will also have a look at the corresponding parameter merge request.
mentioned in merge request !1552 (closed)
added 12 commits
-
a9826cf4...27c113fe - 10 commits from branch
computing:master
- a05e994c - add support for the new geometry format
- 3f58c485 - fix crash in gGeoManager path manipulation
-
a9826cf4...27c113fe - 10 commits from branch
added 31 commits
-
3f58c485...bed4e266 - 29 commits from branch
computing:master
- 6f72bc19 - add support for the new geometry format
- 80b15d88 - fix crash in gGeoManager path manipulation
-
3f58c485...bed4e266 - 29 commits from branch
added 9 commits
-
80b15d88...5d69dc0e - 5 commits from branch
computing:master
- d118c305 - add support for the new geometry format
- 103f4873 - fix crash in gGeoManager path manipulation
- 8be2ceda - replace error messages with debug for output clarity
- 08267392 - replace debug with warn messages
Toggle commit list-
80b15d88...5d69dc0e - 5 commits from branch