[mCBM] Generalize macro to use algo TOF clusterizer as task and gen. YAML files + HowTo
HowTo for now placed close to the macro, may be moved to docs later
Of Interest to @n.herrmann:
this is the macro we discussed this morning which allows to both generate the YAML parameter files and to use an example of Dominik algo
version of the TofHitClusterizer
in the Task
world
For some formatted version of the Howto please have a look at it in my fork (link valid until this MR is merged)
I tested it on the first TS of run 2391 and it went through for me
Merge request reports
Activity
requested review from @d.smith
assigned to @p.-a.loizeau
added 1 commit
- ce01b8de - [mCBM] Generalize macro to use algo TOF clusterizer as task and gen. YAML files + HowTo
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
@p.-a.loizeau @n.herrmann Looks good to me.
I wonder whether we can get rid of the "home/dsmith/" in the path and make it a relative path instead.
I should also mention: All of these parameter setter functions don't actually do anything for
CbmTaskTofClusterizer
. They only exist as to not break the interface, but are actually empty (see the header fileCbmTaskTofClusterizer.h
). Maybe we should remove them? All parameters are read from the yaml file.On the other hand, the yaml generator class
CbmTaskTofClusterizerParWrite
does respond to these functions in the expected way. This was done so that the settings from existing macros can be easily converted to yaml.By the way, looking at
CbmTaskTofClusterizer
again, I don't see any strong reason why it shouldn't also work in event-by-event mode. The wrapper functionality ofCbmTofEventClusterizer
remains mostly in its original form. I won't be able to thoroughly test this before my vacation though. If anyone can find the time, it shouldn't take very long to get this to work.added 30 commits
-
ce01b8de...f6478063 - 29 commits from branch
computing:master
- 932ef8ae - [mCBM] Generalize macro to use algo TOF clusterizer as task and gen. YAML files + HowTo
-
ce01b8de...f6478063 - 29 commits from branch
added 3 commits
-
932ef8ae...466f3e21 - 2 commits from branch
computing:master
- 64567da6 - [mCBM] Generalize macro to use algo TOF clusterizer as task and gen. YAML files + HowTo
-
932ef8ae...466f3e21 - 2 commits from branch
enabled an automatic merge when the pipeline for 64567da6 succeeds