[mCBM] in check timing algo, protect against warning flood in TRD case
This change is to protect against a flood of warning messages in the CI (~ millions messages) when running the check timing test on the 2021 data (run 1588): [WARN] Trd condition not implemented. Skip.
With the change, I get the following restricted output in the test mcbm_chktime_2021_1588
[WARN] Trd condition not implemented for Trd module 37. Skip.
[WARN] Trd condition not implemented for Trd module 53. Skip.
[WARN] Trd condition not implemented for Trd module 5. Skip.
[WARN] Trd condition not implemented for Trd module 21. Skip.
If there is something that should be added to the mCBM 2021 macro macro/beamtime/mcbm2021/check_timing_any.C
to get rid of these just let me know and I would add it to the commit (from loose memories the last changes to this class you introduced to support 2022 data and probably tuned only the corresponding macro)
Edit:
- follow up of !1000 (merged)
- Redmine issue Refs #3089
Merge request reports
Activity
requested review from @a.bercuci
assigned to @p.-a.loizeau
Dear @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 4 commits
-
1d0e8c7d...8d2df157 - 2 commits from branch
computing:master
- 11ac7aeb - [mCBM] in check timing algo, protect against warning flood in TRD case
- 2f8c9eae - [mCBM 2021] Add proper settings for TRD2D in check timing macro
-
1d0e8c7d...8d2df157 - 2 commits from branch
- Resolved by Pierre-Alain Loizeau
Found the setting to add to remove the remaining warnings and added them in a new commit, so now we have a fix both for the flood (symptom) and for the wrong settings (cause)
enabled an automatic merge when the pipeline for a63956bb succeeds
enabled an automatic merge when the pipeline for 9301f64b succeeds
there are 4 tests failing with not understood reasons. For me everything looks reasonable but the
100% tests passed, 0 tests failed out of 201 Total Test time (real) = 1399.37 sec Submit files SubmitURL: https://cdash.gsi.de/submit.php?project=CbmRoot Uploaded: /Users/fairroot/builds/computing/cbmroot/build/Testing/20231117-1007/Test.xml Submission successful Performing coverage Cannot find any coverage files. Ignoring Coverage request. Submit files SubmitURL: https://cdash.gsi.de/submit.php?project=CbmRoot Submission successful _ctest_test_ret_val: 0 _install_ret_value: false -- -- You can find the produced results on the CDash server -- -- CDash Build Summary ..: https://cdash.gsi.de/buildSummary.php?buildid=423565 -- CDash Test List ......: https://cdash.gsi.de/viewTest.php?buildid=423565 -- Running after_script 00:05 Warning: Permanently added '[localhost]:11129' (ECDSA) to the list of known hosts. Running after script... $ rm -rf build Cleaning up project directory and file based variables 00:01 Warning: Permanently added '[localhost]:11129' (ECDSA) to the list of known hosts. ERROR: Job failed: exit status 1
Do you have an idea what could be the problem? In my opinion unrelated to code changes.
I try to rerun them now that I see some other MRs have managed to have all runners in CDASH: I suspect it was something with the name resolution/routing on some of our runners (I saw also one job this morning where everything worked but it failed just because it could not resolve
https://cdash.gsi.de
)enabled an automatic merge when the pipeline for 8d50c4c8 succeeds
mentioned in merge request !1325 (merged)