Removed structured bindings from cbm::algo::tof::Hitfind.

Changes requested by @f.uhlig.

Please merge if this fixes the problem.

added BugFix Online labels

requested review from @f.uhlig

assigned to @f.uhlig

Dear @n.herrmann, @i.deppner,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

@f.uhlig, Is it possible to enable openmp on one of the MacOS jobs, so this is caught by the CI in the future?

approved this merge request

@fweig,

I think OpenMP is enabled in the macosx CI runners. In my opinion the problem ist that I have an Apple Silicon which is based on ARM. But I will crosscheck the CI runners if OpenMP is enabled or not. I am sure that I haven't had the problem with my Desktop which is a Mac mini but there I have slightly different OS and compiler.

@d.smith,

thanks for the fix. This actually solves my problem and sorry for the harsh reply this morning. I wnated to finish something and after updating CbmRoot I was in the described trap.

added 3 commits

• 2e190982...8d2df157 - 2 commits from branch computing:master
• cead145f - Removed structured bindings from cbm::algo::tof::Hitfind.

Compare with previous version

enabled an automatic merge when the pipeline for cead145f succeeds

merged

@f.uhlig, pretty sure this is an issue in the clang frontend and is independent from architecture. It's also reproducable on older clang versions. What probably changed on the newer MacOs version is that OpenMP is enabled by default. On older versions it's disabled by default and enabling it was a bit finicky, if i remember correctly.

The MacOs runner failed with OpenMP for me. That's why we have this wrapper to provide a fallback if it's not available.

mentioned in merge request !1899 (closed)