Fix event based digitization and reconstruction for the MVD detector

changed milestone to %OCT23

added BugFix CI/CD Reconstruction Simulation labels

requested review from @p.-a.loizeau

requested review from @v.friese and removed review request for @p.-a.loizeau

added 1 commit

cde8a677 - Fix the reconstruction topology

I reran the test on run4 and accessed the temp log file in order to get the non-truncated logs of the failing test (see MR1504_failing_test_log_untrunc_2023_11_16_11_45.txt for the test full log).

It seems that the failure comes from the following error:

[...]
Error in <TH2F::Interpolate>: Cannot interpolate outside histogram domain.
Error in <TH2F::Interpolate>: Cannot interpolate outside histogram domain.
[INFO] Event based mode

[INFO] MCEvent 9 with T0 -1
[INFO] Writing MC-tracks from event # 8 file 0
[FATAL] CbmMatchRecoToMC::MatchClusters => no Match found for system 1 digi index 7373 (digi 1 from cluster 0) !
For later analysis we write a core dump to core_dump_32448
<end of output>
Test time =  65.86 sec
----------------------------------------------------------
Test Fail Reason:
Required regular expression not found. Regex=[Test Passed
All ok

Not sure how 2 runners managed to pass the test while all others fail it

mentioned in merge request !1493 (closed)

Supersedes !1493 (closed). Fix both, the event based digitization and cluster finding.

added 6 commits

cde8a677...cead145f - 3 commits from branch computing:master
2600af3c - Fix generation of MvdDigi in event based mode
7b8de4db - Add back event mode in MVD cluster finder
f4d3a63c - Fix the reconstruction topology

Compare with previous version

added 3 commits

419eaa5c - Fix generation of MvdDigi in event based mode
73894911 - Add back event mode in MVD cluster finder
157f44ce - Fix the reconstruction topology

Compare with previous version

added 1 commit

11e28fe3 - Next try

Compare with previous version

added 5 commits

5c7893f5 - 1 commit from branch computing:master
fdc131e1 - Fix generation of MvdDigi in event based mode
daca5ade - Add back event mode in MVD cluster finder
f8993128 - Fix the reconstruction topology
5b04eb42 - Next try

Compare with previous version

added 3 commits

84ce846a - Fix generation of MvdDigi in event based mode
c47fff72 - Add back event mode in MVD cluster finder
1e5d886d - Fix the reconstruction topologies at several places

Compare with previous version

added 1 commit

8eb8f942 - Fix the reconstruction topologies at several places

Compare with previous version

Dear @f.uhlig, @p.-a.loizeau, @c.muentz, @m.deveaux, @v.friese,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

@m.deveaux,

please have a look at the changes to the MVD digitizer and cluster finder and do a cross check. In case of event based reconstruction I simply (at least that is what i tried) use all digis from the time slice for digitization and cluster finding. Up to now I did not find the time to check the results by comparing hits to MC points but hope to do it beginning of next week.

added 9 commits

8eb8f942...4f519993 - 5 commits from branch computing:master
652db4cd - Fix generation of MvdDigi in event based mode
cd7c4e3b - Add back event mode in MVD cluster finder
f23e47fa - Fix the reconstruction topologies at several places
07e757d7 - Add event based CI tests fore MVD QA

Compare with previous version

added 1 commit

8a8d2da3 - Add event based CI tests for MVD QA

Compare with previous version

changed the description

@f.uhlig As you add new CI based on the existing macros for which I found many warnings in #3088 (..._qa3_... and ..._qa4_...), could I ask you to apply the two changes mentioned by Michael in the issue to the 4 macros (2 original and 2 new)?

added 1 commit

22d526dd - Use INFO level for logging

Compare with previous version

Unfortunately when I built this commit, it didn't solve the MVD hit problem as far as I could see.

root [6] cbmsim->Scan("MvdHit.fX")
***********************************
*    Row   * Instance * MvdHit.fX *
***********************************
*        0 *        0 *           *
*        1 *        0 *           *
*        2 *        0 *           *
*        3 *        0 *           *
*        4 *        0 *           *
***********************************
(long long) 5
root [7] .q

PS: I followed steps in https://redmine.cbm.gsi.de/issues/3074#change-14808