Skip to content
Snippets Groups Projects

Fixed cbm::algo::tof::Hitfind::CalibRawDigis(). Changed interfaces accordingly.

Merged Dominik Smith requested to merge d.smith/cbmroot:TofHitfinderCalibFix into master

Restored the original functionality of CalibRawDigis(), while keeping the gsl::span implementation.

In order to preserve the possibility of storing the calibrated digis, the return type of cbm::algo::Hitfind() was changed from std::pair to std::tuple. This requires minimal changes of the calling code.

Remark: The cause of the initial bug was confusion which arose from the fact that cbm::algo::Hitfind() modified its input (replacing raw digis by calibrated digis in the input vector), in violation of the single responsibility principle. The calibrated digis are now properly part of the return-type instead, and the input is unchanged.

Merge request reports

Merge request pipeline #25027 passed

Merge request pipeline passed for ca3740dc

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 4 commits will be added to master.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading