WIP: Synchronize std and kronos macros for mCBM2020 event building, refs #1827

The macros for the mCBM 2020 event builder based on time windows are slightly diverged:

• Examples for some parameters were missing in the kronos version of the macro (but still consistent due to default values)
• The PSD upper limit of the time window was up to date only in the kronos version

No urgency as the kronos version was in a state were the common files could be generated.

@p.-a.loizeau,

why do we need two macros which can diverge in the first place. I don't see dramatic differences between both files so wouldn't it be better to have only one file.

The Kronos version is for compatibility with our current slurm: it is iterable and has hard-coded path for the lustre file-system (otherwise I had to do lots of bash voodoo in the submission script).

Indeed once we go to the new cluster and prepare tests running on it, we may have the opportunity to improve our Slurm support and merge the macros

Could you please check, but at least for the event building macros I don't see any kronos related hard coded paths.

I added the possibility in the "kronos" version to provide an optional Run ID. This should allow later to remove the non-kronos one.

The commits should be squashed as I messed up (again ^^') with the formatting.

When reviewing the MR !148 (closed) , I in fact just realized that the "kronos" version should be using the commonly unpacked file to be most "user-friendly". So I will in fact introduce hard-coded paths in this one.

Switching to WIP until I reach a better state.

added 1 commit

• 4ace74b9 - Add optional support for Run ID outside of list in kronos evt macro to later keep only one version

Compare with previous version

added 6 commits

• 4ace74b9...05bbbedb - 4 commits from branch computing:master
• 9f28a47b - Synchronize std and kronos macros for mCBM2020 event building, refs #1827
• 7f596fa5 - Add optional support for Run ID outside of list in kronos evt macro to later keep only one version

Compare with previous version

added 1 commit

• 053de556 - Fix formatting

Compare with previous version

added 1 commit

• 757b7b50 - Fix formatting

Compare with previous version

added 6 commits

• 757b7b50...f5403201 - 2 commits from branch computing:master
• 5a1ec4bf - Synchronize std and kronos macros for mCBM2020 event building, refs #1827
• 0b57d99e - Add optional support for Run ID outside of list in kronos evt macro to later keep only one version
• b40c0800 - Fix formatting
• 2ddecc07 - Fix formatting

Compare with previous version

marked as a Work In Progress

Closed as included in !156 (merged)

closed