algo: Move histogram sending into own class and add flag for server address.
@p.-a.loizeau, some more integration of the histogram sender into the online binary.
Merge request reports
Activity
added Online label
requested review from @p.-a.loizeau
assigned to @fweig
added 5 commits
-
e806b550...51878292 - 4 commits from branch
computing:master
- f378c7ff - Move histogram sending into own class.
-
e806b550...51878292 - 4 commits from branch
Dear @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Felix Weiglhofer
Looks good.
Do you think we should update the documentation in docs/histservs/HowTo.md around l.143-149 right now or should we wait until after the DC when we have testing thing and maybe a stable procedure?
- Resolved by Felix Weiglhofer
@fweig One thing I missed: we need to add a destructor to
HistogramSender
to close the socket and the context (the vlock which was in theEventBuildChain
destructor).Not critical in itself but may otherwise lead to trouble if we stop the online process and restart a new one soon after, as ZMQ may complain that the port is still in use
added 6 commits
-
f378c7ff...a9c1a566 - 4 commits from branch
computing:master
- b03f334b - Move histogram sending into own class.
- f622723a - Update README.
-
f378c7ff...a9c1a566 - 4 commits from branch
added 2 commits
enabled an automatic merge when the pipeline for 24028391 succeeds
- Resolved by Felix Weiglhofer
Gitlab is showing me only the commit with the Readme update, is it something on my side? (must confess my system is unstable since the last update of Firefox and Thunderbird)