bugfix in the StsSetup

This MR fixes the following compiler warning:

/home/cbmdock/cbmroot/core/detectors/sts/CbmStsSetup.cxx: In member function 'void CbmStsSetup::RecomputePhysicalAssmbBbox(TGeoManager*)':
/home/cbmdock/cbmroot/core/detectors/sts/CbmStsSetup.cxx:382:59: warning: unused parameter 'geo' [-Wunused-parameter]
 void CbmStsSetup::RecomputePhysicalAssmbBbox(TGeoManager* geo)
                                              ~~~~~~~~~~~~~^~~

The problem is that RecomputePhysicalAssmbBbox() method uses gGeoManager instead of the input variable "geo". It doesn't matter much because, in the calling code, the "geo" variable is always initialized with gGeoManager. But for consistency, one should either remove the "geo" input variable and always use gGeoManager, or use the variable. I don't know which way is better. I rewrote the code so that it uses the variable.

added BugFix label

requested review from @v.friese

assigned to @v.friese

changed the description

Dear @v.friese,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

approved this merge request

Huuum, nice find, if I remember I kept the geoManager pointer at input to match the corresponding function in the FairRoot alignment class, from which part of this was originally copied, but then did not keep track while modifying it with proposals from the CERN experts. So I am guilty of this one

Anyway hopefully we can get rid of this hack once we switch to the newer FS+FR (which contains this fix on the FR side) after the release

added 4 commits

• 1f7b1285...83b422bf - 3 commits from branch computing:master
• a182a361 - bugfix in the StsSetup

Compare with previous version

enabled an automatic merge when the pipeline for a182a361 succeeds

merged

added WarnFix label