macro/beamtime/mcbm2022/mcbm_event_reco_L1.C: turing off FSD in the event builder
This merge request adds the FSD flag to the mcbm_event_reco_L1.C macro main function signature and disables FSD in the event builder.
@p.-a.loizeau , could you please add this macro to the CI-tests?
Merge request reports
Activity
added Reconstruction mCBM labels
requested review from @se.gorbunov
assigned to @p.-a.loizeau
added 1 commit
- 43e894a2 - macro/beamtime/mcbm2022/mcbm_event_reco_L1.C: turned off FSD in the event builder
added 1 commit
- 447155b0 - macro/beamtime/mcbm2022/mcbm_event_reco_L1.C: turned off FSD in the event builder
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
OK for me for the changes introduced.
Concerning the CI:
This macro is not in the CI as it was hard to find if problems/processing speed slowdown were coming from the event building or from the reco.
So instead we have the two macrosmcbm_event.C
andmcbm_reco.C
.
Unfortunately as thereco
macro tests are already the longest running ones in both the CI (order 5 min for 1 TS out of total 25-30) and the Nightly (order 40 mins each for 20 TS out of 3 hours), I do not think we can easily add one more reco macro.The two thing I could propose would be to
- either to add it to the nightly tests with a single TS
- or to add it to the weekly tests with a single TS
Long term I would also like to have all these event building macros and reco macros converged to a single version of each to be used both for simulation and real data, in order to reduce the confusion, but I suspect this will only happen when we create the
mcbm2024
macro folder@s.zharko, Why do we need a particular macro for running with L1? Can't L1 tracker be added to the mcbm_event.C macro (with a switch)?
added 5 commits
-
447155b0...5471d2cd - 4 commits from branch
computing:master
- 83b422bf - macro/beamtime/mcbm2022/mcbm_event_reco_L1.C: turned off FSD in the event builder
-
447155b0...5471d2cd - 4 commits from branch
enabled an automatic merge when the pipeline for 83b422bf succeeds