Switching from NicaFemto to HAL

added 1 commit

a79c283f - Fix missing line.

added 4 commits

a79c283f...1aa44641 - 2 commits from branch computing:master
9dd256a9 - Switching from NicaFemto to HAL
5ddda947 - Fix missing line.

@wielanek_AT_if.pw.edu.pl,

I had a look into your MR. When compiling a rebased version of your MR I get the following compilation error on my macosx

/Users/uhlig/software/fair/cbm/cbmroot_git/external/Hal/analysis/femto/base/shmath/FemtoYlmSolver.cxx:646:15: error: variable-sized object may not be initialized
    double vL[fMaxJM * 2] = {0};
              ^~~~~~~~~~
1 error generated.
make[5]: *** [analysis/femto/CMakeFiles/HalFemto.dir/base/shmath/FemtoYlmSolver.cxx.o] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from /Users/uhlig/software/fair/cbm/cbmroot_git/external/Hal/fair/QAManagerBasic.cxx:14:
/opt/fairroot/v18.8.0_nov22p1/include/FairRun.h:16:10: fatal error: 'TMCtls.h' file not found
#include <TMCtls.h>   // for multi-threading
         ^~~~~~~~~~
1 error generated.

The first error is due to the used GCC extension which isn't allowed by the C++ standard. You have to create the variable-sized array with new. Don't forget to destroy it after usage or even better use a unique_ptr such that the destruction is done automatically.

The second problem is due to the fact that with new ROOT versions VMC isn't any longer a part of ROOT but an independent package. You need to add the proper include directory such that the header file can be found. Please check the CbmRoot build system for reference.

added 1 commit

ab4192ed - Update InstallHal.cmake

Switching from NicaFemto to HAL

Merge request reports

Activity