Add new CMake target to run clang-tidy

Refs #2969

The target will run clang-tidy on all changed source and header files The target is only created if the used clang-tidy supports all required checks. The required checks will be extracted from the clang-tidy configuration file, so the list should be alwyas correct.

Instead of having a hardcoded list of required checks the list is extracted from the clang-tidy config file such that the list is always up to date.

Add CMake script to execute the TidyCheck in our CI

Download and install external packages needed when running clang-tidy. To speed up things execute clang-tidy in parallel on differnt files if more cores are available.

Add shell script used by the CMake target

Check changed header files only if there is a corresponding source file in the compile_commands database. Currently there is no way to test header files without corresponding source file (compilation unit). Create missing but expected output directories. Remove clang-tidy command line option The option was moved to the config file.

The script find_files.sh is now used from two places so pass the required information as parameters. Remove one unneded parameter

Add and disable clang-tidy test in the CI chain

The check is disabled since it isn't yet decided if clang-tidy should be integrated in the CI chain.

cmake/modules/CbmTargets.cmake

@@ -26,7 +26,7 @@ macro(define_additional_targets)
 
     # Create a list C, C++ and header files which have been changed in the
     # current commit
-    execute_process(COMMAND ${CMAKE_SOURCE_DIR}/cmake/scripts/find_files.sh
+    execute_process(COMMAND ${CMAKE_SOURCE_DIR}/cmake/scripts/find_files.sh ${BASE_COMMIT}
                     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
                     OUTPUT_VARIABLE FileList
                     OUTPUT_STRIP_TRAILING_WHITESPACE
@@ -58,6 +58,50 @@ macro(define_additional_targets)
 
   endif()
 
+  find_package2(PRIVATE ClangTidy)
+  if(ClangTidy_FOUND AND EXISTS ${CMAKE_SOURCE_DIR}/.git)
+    if (FAIRROOT_TIDY_BASE)
+      set(BASE_COMMIT ${FAIRROOT_TIDY_BASE})
+    else()
+      set(BASE_COMMIT upstream/master)
+    endif()
+
+    # Create a list C, C++ and header files which have been changed in the
+    # current commit
+    execute_process(COMMAND ${CMAKE_SOURCE_DIR}/cmake/scripts/find_files.sh ${BASE_COMMIT}
+                    WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+                    OUTPUT_VARIABLE FileList
+                    OUTPUT_STRIP_TRAILING_WHITESPACE
+                   )
+    string(REGEX REPLACE " " ";" FileList "${FileList}")
+
+    # Loop over the files and create the code whch is executed when running
+    # "make FormatCheck".
+    # The produced code will run clang-format on one of the files. If
+    # clang-format finds code which are not satisfying our code rules a
+    # detailed error message is created. This error message can be checked on
+    # our CDash web page.
+    foreach(file ${FileList})
+
+      set(file1 ${CMAKE_BINARY_DIR}/${file}.ct_out)
+
+      list(APPEND myfilelist1 ${file1})
+      add_custom_command(OUTPUT ${file1}
+                         COMMAND ${CMAKE_SOURCE_DIR}/cmake/scripts/check-tidy.sh ${file} ${file1} ${CMAKE_BINARY_DIR}
+                         WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+                        )
+    endforeach()
+
+    # Create the target FormatCheck which only depends on the files creted in
+    # previous step. When running "make FormatCheck" clang-format is executed
+    # for all C, C++ and header files which have changed in the commit.
+    add_custom_target(TidyCheck
+                      DEPENDS ${myfilelist1}
+                      )
+
+  endif()
+
+
 # TODO: check if still needed
 #  if(RULE_CHECKER_FOUND)
 #    ADD_CUSTOM_TARGET(RULES