Draft: Remove deprecated system headers

Many system headers like e.g. assert.h are deprecated in C++14. One should use
corresponding C++ headers like e.g. cassert. With this commit all deprecated
headers are excahnged by the proper C++ versions.

A list of these headers can be found at
https://clang.llvm.org/extra/clang-tidy/checks/modernize/deprecated-headers.html

requested review from @p.-a.loizeau

assigned to @p.-a.loizeau

added 1 commit

• 8d9df39d - Fix clang format

Compare with previous version

added 1 commit

• a2b051bd - Add needed namespace

Compare with previous version

Dear @f.uhlig, @p.-a.loizeau, @wielanek_AT_if.pw.edu.pl, @v.friese, @s.lebedev, @v.singhal, @karpushkin_AT_inr.ru, @n.herrmann, @i.deppner, @a.bercuci, @p.kaehler, @se.gorbunov, @v.akishina,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

I see that you fixed only .cxx files and if I understand the bottom of the clang-tidy docu page right, by default it does not check the header files.

Not 100% sure as with ROOT it may backfire, but shouldn't we try to set the flag to also check the headers?
as in principle CbmRoot is the "top of the pyramid" library in our workflow, so anything built while including it should be pure C++

@p.-a.loizeau,

in principle I set the flag in the configuration, so I am not sure if it didn't work or if there are really no old headers in the header files. I will check again.

@p.-a.loizeau,

good catch. Beside the flag I already set there was another one which was missing. This is now fixed and I also see changed header files. One thing still to check is if it is possible to format the code automatically after it was changed. For example when changing <assert.h> to clang-format may complain afterwards since the header files may now be in a wrong order.

closed