[Bug fix] mCBM: Update of /macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
In this merge request, several bugs in the mcbm_event_reco_L1.C macro are fixed:
- Previously, the CBM module activation scheme did not work properly: the requests of disabling the modules, which are originally enabled by the setup, were ignored. In the merge request it is fixed.
- Enumeration entry of kCbmRecoEvent is out-dated. It was replaced with ECbmRecoMode::EventByEvent.
- The Enumeration CbmStsSensorClass is not accessible from ROOT macros any more, thus the CbmStsParSensor instantiation with the parameter CbmStsSensorClass::kDssdStereo was replaced with the call of the default constructor, where this enumeration entry is set by default.
---- Update: Changes from the point 3 seems not to be applied, thus only the points 1 and 2 are addressed now.
Merge request reports
Activity
added BugFix Reconstruction mCBM labels
requested review from @p.-a.loizeau
assigned to @v.friese
added 1 commit
- 0f947423 - Bugfix in the macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
added 1 commit
- 811f2285 - Bugfix in the macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
added 1 commit
- c13719de - Bugfix in the macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
Does this apply also to
macro/beamtime/mcbm2022/mcbm_reco.C
?I yes, could you please also do the changes to this macro? This is the one which is tested by the CI
Edit: after a more careful look, I think only point 3 would be missing in this other macro
Edited by Pierre-Alain LoizeauDear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 1 commit
- 023edc18 - Bugfix in the macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
@p.-a.loizeau, I tested the mcbm_reco.C macro, and it didn't crash. After that I decided to return the CbmStsSensorClass::kDssdStereo as an init parameter for the sensor6cm object in the mcbm_event_reco_L1.C, and it worked as well. I have no idea, why it crashed in the first place, but I decided to leave the CbmStsSensorClass::kDssdStereo where it originally was
Edited by Sergei Zharkoadded 9 commits
-
023edc18...eed1fae4 - 8 commits from branch
computing:master
- e6d72e0a - Bugfix in the macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
-
023edc18...eed1fae4 - 8 commits from branch
added 31 commits
-
e6d72e0a...d41d7551 - 30 commits from branch
computing:master
- fc28706e - Bugfix in the macro/beamtime/mcbm2022/mcbm_event_reco_L1.C
-
e6d72e0a...d41d7551 - 30 commits from branch