Skip to content
Snippets Groups Projects

Improvements to PWG_common_production

Merged Lukas Chlad requested to merge l.chlad/cbmroot:pwg_common_production into master
1 unresolved thread

This should help to fix the issue of unknown RemoveGeoManager() procedure which could occur.

Also change to new FairRoot setting of output file.

The possibility of specifying in config.json range of jobs and non-batch mode should be handled appropriately now.

In running analysis tree convertor, the variables of ts_length and is_event_base are interconnected.

related redmine: https://redmine.cbm.gsi.de/issues/2950

Edited by Lukas Chlad

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lukas Chlad added 5 commits

    added 5 commits

    • 1f1496c6 - Fix typo, will allow automatic check of job status
    • 8b1cd114 - Remove not well described is_event_base
    • 3462d5e4 - Fix typo of reported macro name in CheckOutFileName
    • 04d16704 - Automatic insertion of caller function name in CheckOutFileName
    • a018005c - Replace const bool inside function by parameter passed to a function

    Compare with previous version

  • Lukas Chlad added 20 commits

    added 20 commits

    • a018005c...dcaf4d39 - 5 commits from branch computing:master
    • dcaf4d39...6108e1e5 - 5 earlier commits
    • 83a16ac8 - Check when copying if the files are different, possible non-batch farm running of range of jobs
    • b3272178 - Apply clang-format
    • 4d6d8b8f - Missing empty line
    • 0676593f - Fix MacOS missing -u option for cp
    • 1bd45155 - Fix typo, will allow automatic check of job status
    • 8c385273 - Remove not well described is_event_base
    • 640b4962 - Fix typo of reported macro name in CheckOutFileName
    • 2a471846 - Automatic insertion of caller function name in CheckOutFileName
    • fff7ec29 - Replace const bool inside function by parameter passed to a function
    • 66ad4ae8 - Apply clang-format

    Compare with previous version

  • Lukas Chlad changed the description

    changed the description

  • 3 3 Authors: Viktor Klochkov, Frederic Linz [committer] */
    4 4
    5 5 // ----- Check output file name -------------------------------------------
    6 bool CheckOutFileName(TString fileName, Bool_t overwrite)
    6 bool CheckOutFileName(TString fileName, Bool_t overwrite, const char* caller = __builtin_FUNCTION())
  • Florian Uhlig resolved all threads

    resolved all threads

  • @f.kornas,

    since you agreed to the MR in the Redmine issue and there are no more open issues here I merge the MR.

  • Florian Uhlig approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading