Rich: add index to each PMT pixel by sorting translations inside its pmt volume
Assign each pmt pixel an index [0, 63] by sorting pixel volume translations inside its pmt volume.
This will result in a easy pixel numbering scheme (independent of pixel paths in the geometry -> version independant).
Neighbor pixels can now be easily determined and e.g. crosstalk implemented (following soon).
Row major, view upstream.
x→ | ||||||||
↓y | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 |
8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | |
16 | 17 | 18 | 19 | 20 | 21 | 22 | 23 | |
24 | 25 | 26 | 27 | 28 | 29 | 30 | 31 | |
32 | 33 | 34 | 35 | 36 | 37 | 38 | 39 | |
40 | 41 | 42 | 43 | 44 | 45 | 46 | 47 | |
48 | 49 | 50 | 51 | 52 | 53 | 54 | 55 | |
56 | 57 | 58 | 59 | 60 | 61 | 62 | 63 |
Merge request reports
Activity
Dear @s.lebedev,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Martin Beyer
could you propose a reviewer who can judge on the implementation.
assigned to @f.uhlig
- Resolved by Martin Beyer
added 35 commits
-
a21d52e0...ad0e4be8 - 24 commits from branch
computing:master
- 4fb32541 - 1 earlier commit
- ec639189 - add capability to get neighbour pixels by address for direct, diagonal and NxN grid pixels
- d8f003dc - fix conditions
- 5aabf796 - Apply clang-format
- ad2e6b79 - reduce 2 indices into 1 pixel index, removal of local translations inside...
- d0915d45 - apply clang-format
- fe9ae178 - wrong address fix for mRICH
- d710a227 - comment changes
- f5512755 - sorting change and cosmetics
- 9650eaf2 - apply clang-format
- 9526e986 - change date
Toggle commit list-
a21d52e0...ad0e4be8 - 24 commits from branch
mentioned in merge request !1272 (merged)
added 29 commits
-
9526e986...b6e36593 - 18 commits from branch
computing:master
- 1be5da0f - 1 earlier commit
- f3c98a2c - add capability to get neighbour pixels by address for direct, diagonal and NxN grid pixels
- 01a0ef84 - fix conditions
- deea363f - Apply clang-format
- cc95e24a - reduce 2 indices into 1 pixel index, removal of local translations inside...
- 917be923 - apply clang-format
- 242cf171 - wrong address fix for mRICH
- 48f57a86 - comment changes
- 66892f7b - sorting change and cosmetics
- 45e30ced - apply clang-format
- c68de784 - change date
Toggle commit list-
9526e986...b6e36593 - 18 commits from branch
enabled an automatic merge when the pipeline for c68de784 succeeds