TRD Incomplete cluster recognition
This merge request changes the behavior of the TRD 1D Clusterizer to set the charge of clusters recognized as incomplete to -1. Clusters can be incomplete because of missing neighbor-triggered digis which are lost due to buffer overflows in the electronics at high load (or in rare cases masked channels).
See redmine issue https://redmine.cbm.gsi.de/issues/2849
Merge request reports
Activity
Dear @a.bercuci, @p.kaehler,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 23 commits
-
8b9ddc80...4eab7686 - 21 commits from branch
computing:master
- 418e0618 - Add Incomplete Cluster Recognition
- 3e4a25b1 - Apply clang-format
-
8b9ddc80...4eab7686 - 21 commits from branch
added 53 commits
-
3e4a25b1...bba4c544 - 51 commits from branch
computing:master
- 6a4c13b6 - Add Incomplete Cluster Recognition
- 68e7d0bd - Apply clang-format
-
3e4a25b1...bba4c544 - 51 commits from branch
- Resolved by Axel Puntke
@p.-a.loizeau @f.uhlig This is on TRD-1D clusterisation. By signature of our hit types we identify "obviously" incomplete clusters, in which part of the charge (single channels) are missing.
- such incomplete clusters shall still contribute to tracking, thus generate still a hit
- as the overall charge (dE) is known only to some fraction (*), the charge value should not be used
Please recommend us how to set the charge value of such hits from incomplete clusters.
- "0", to make it not contributing to spectra
- "-1" as semi-canonical exception value, to trigger awareness
- "NaN" to use high language
After having defined (and set correspondingly in the code) we request merging, if no objections.
(*) One might consider trying reconstructions of such missing charges, as we know the PRF enveloping all. However we consider this as different/future project.
Edited by Philipp Kaehler
added 21 commits
-
68e7d0bd...84533b57 - 16 commits from branch
computing:master
- 1feafd20 - Add Incomplete Cluster Recognition
- 8b9ddc80 - Apply clang-format
- 050c765a - Changed charge of Hits originating from incomplete TRD clusters to -1 instead of zero
- 693a148c - Merge branch 'master' of git.cbm.gsi.de:computing/cbmroot into incompl_cluster_recog
- 03ddf5ce - Merge branch 'incompl_cluster_recog' of https://git.cbm.gsi.de/apuntke/cbmroot...
Toggle commit list-
68e7d0bd...84533b57 - 16 commits from branch
- Resolved by Axel Puntke
added 1 commit
- b9fdd239 - Setting charge of Hits originating from incomplete TRD clusters to -1 instead of 0
added 91 commits
-
b9fdd239...84533b57 - 89 commits from branch
computing:master
- 4c5d2f62 - Squashed last 3 commits
- 0ed778b7 - Setting charge of Hits originating from incomplete TRD clusters to -1 instead of 0
-
b9fdd239...84533b57 - 89 commits from branch
added 9 commits
-
0ed778b7...681bc153 - 7 commits from branch
computing:master
- 776e1610 - Squashed last 3 commits
- f60a7c7a - Setting charge of Hits originating from incomplete TRD clusters to -1 instead of 0
-
0ed778b7...681bc153 - 7 commits from branch
enabled an automatic merge when the pipeline for f60a7c7a succeeds
mentioned in merge request !1512 (merged)
mentioned in merge request !1634 (merged)