Draft: FSD integration to CBM-ROOT
At most of the places, the code is taken from PSD and add some changes specific to FSD design.
Merge request reports
Activity
added 1 commit
- e78c9e6e - Update Geometry version, still in l.chlad repo
Dear @f.uhlig, @v.friese, @p.-a.loizeau, @i.selyuzhenkov, @v.singhal, @a.bercuci, @p.kaehler, @d.smith, @e.lavrik,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
@f.uhlig This is a large one, if one considers the number of changed files. May I suggest to split the review - you look into core, I into sim and reco?
requested review from @f.uhlig
assigned to @v.friese
Since the MR is mainly independent of the existing code since it simply adds a new detector I would propose to break it up into smaller pieces. One way would be to first add the directories with the new code, maybe even in more than one MR and only with later merge requests adding it to the simulations.
mentioned in merge request !1188 (merged)
added 100 commits
-
142c4de5...0c8ddfda - 34 commits from branch
computing:master
- 0c8ddfda...22a898e1 - 56 earlier commits
- 9d6345b5 - FSD hit anatree converter update
- ac2af2c3 - Fix installation in FSD Digitization name change
- 2e1c7e62 - Apply clang-format
- 8c290dcd - Remove obsolete run ATMaker macro
- 67a474d6 - Modify copyright info
- a190c888 - Modify the weight of link to be energy loss, plus copyright info
- 71880e1a - Add empty line to end of cmakelist
- 10a02a4f - Update Geometry version, still in l.chlad repo
- e4147f29 - Fixing CI reco tests
- a708f164 - Fix Real data test
Toggle commit list-
142c4de5...0c8ddfda - 34 commits from branch
please don't update this MR for the time being. If you always do it in parallel to the !1188 (merged) you simply double the load on the CI runners.
@f.uhlig Can't we label this MR draft? I understand it will be superseded by coming MRs.
Fine with me. I changed it to Draft mode.
mentioned in merge request !1262 (merged)
mentioned in merge request !1291 (merged)