STS update: Time Walk + masking of noisy channels

• Update CbmStsParAsic to contain 31 parameters for time walk correction
• Update StsUnpack classes to read the new 31 parameters scheme
• Update unpacker macro to read time walk parameters from the file
• Update unpacker to read and mask noisy channels from the file

changed the description

assigned to @p.-a.loizeau

requested review from @v.friese

Dear @v.friese, @f.uhlig, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

Just for my understanding: You have now 31 parameters per ASIC for the walk correction. There are 31 possible ADC values, I think. So, there is no functional parametrisation of the walk effect (by a polynomial or so), but just plain values, one for each ADC channel? Is this motivated by avoiding the repeated calculation during unpacking?

@d.smith Please have a look. This is most probably relevant also for the new unpacker in algo.

You are correct. There is no functional parameterization of the walk effect anymore. Before, the parametrized function was mapped at the unpacked configuration, so the evaluation was done only once per ASIC. Therefore, even with four parameters per ASIC, 31 were loaded to memory to avoid repeated calculation. No difference in memory efficiency. The motivation for having 31 parameters comes from the method to calculate such offset values. For the polynomial method; minimal calibration issues lead to catastrophic results with very wrong time-walk correction because the polynomial parameters are obtained by the attempt to fit a data set that does not match the data distribution.

added 1 commit

• e2dc5ab2 - STS time walk: fix container size to 31

Compare with previous version

added 1 commit

• b5de55ee - CLANG formatting

Compare with previous version

resolved all threads

added 9 commits

• b5de55ee...ae306961 - 3 commits from branch computing:master
• 8a04dc4c - Update sts noise removal during unpacking (macro level)
• 740b5ac6 - Update sts time walk correction
• 635f2d17 - CLAG formatting
• df08b35c - STS time walk: fix container size to 31
• e7201d2d - CLANG formatting
• e2eb1e49 - Merge branch 'sts_unp_mask_noisy' of https://git.cbm.gsi.de/d.ramirez/cbmroot...

Compare with previous version

resolved all threads

approved this merge request

added 5 commits

• 54d45192 - Update sts noise removal during unpacking (macro level)
• 35e19cb6 - Update sts time walk correction
• 5440683b - CLAG formatting
• 02a14043 - STS time walk: fix container size to 31
• 64321a41 - CLANG formatting

Compare with previous version

merged