Update STS offsets and noisy channels

Update STS offsets and noisy channels in unpacker macro (run 831)

Part of issue #1827

closed

reopened

closed

assigned to @d.emschermann

Hi Alberica,

I think the checks are stuck due to the same problem as the one encountered by Adrian yesterday: the forking procedure do not copy all auto-check settings from the main repository.
David or Florian will have to enable for your fork the servers on which we check the code.

@d.emschermann Could you please do the same procedure as we did for Adrian yesterday with runner #40 and #69? Thanks in advance

Once it is done, the steps should restart automatically.
If you have extra modifications coming later, you can re-close this MR, otherwise I think it will work.

reopened

Hi Alberica, hi Pierre,

I have just enabled Albericas cbmroot queues for Linux and MAC. Please retrigger if it does not start by itself.

assigned to @a.toia and unassigned @d.emschermann

Hi David, hi Pierre if I am doing the right thing, it seems to me that it fails now in the FormatCheck

Yes, I saw it and I think the formatting really does not help the user here. As a hack, could you please add the following lines before the big switch() case::

  /// FIXME: Disable clang formatting for parameters tuning for now
  /* clang-format off */

and the following ones after:

  /// FIXME: Re-enable clang formatting after parameters tuning
  /* clang-format on */

added 1 commit

• 9c04ec63 - Update macro/beamtime/mcbm2020/unpack_tsa_mcbm.C,...

Compare with previous version

ok done

Sorry, I missed the fact that the noisy channels are outside of the switch/case ^^' You should put the first block before them

added 1 commit

• a1eac153 - Update unpack_tsa_mcbm.C

Compare with previous version

added 1 commit

• 8ec8fd9e - Update unpack_tsa_mcbm_kronos.C

Compare with previous version

now the first FIXME is before the changes and the second is after

Hummm, for the remaining one it seems to be linked to some leftover spaces in an empty line. Could you have a look at this cdash output and try to change it? https://cdash.gsi.de/viewBuildError.php?buildid=249065

sorry... i do not quite get what I should change...

If I trust the cdash output, lines with only spaces are forbidden. So you should remove the spaces/tabs in l.543 in unpack_tsa_mcbm.C and l.669 in unpack_tsa_mcbm_kronos.C

added 1 commit

• 3b5e0e26 - Update macro/beamtime/mcbm2020/unpack_tsa_mcbm.C,...

Compare with previous version