StsSetup: replace BBox recompute fct w/ one proposed by ROOT expert, #2620

• cf https://github.com/root-project/root/issues/12242
• Fixes edge case of #2620 which was missed by previous patch

Problem description (also valid for similar patch in Fairroot v18.8.0 and v18.8.1):

1. previous re-computation patch is only applied to Assemblies which are Physical Nodes (first check if PhysicalNode, then if Assembly)
2. by default, Assemblies do not have/are not PhysicalNodes
3. the alignment procedure forces a PhysicalNode creation/conversion only on the nodes being aligned

=> If only lower levels inside the assemblies (e.g. Sensors but no Station) were aligned, the Assemblies were not recomputed

Handles problem reported by @a.bercuci without needing fix/trick on the user side
Needed until we deprecate support for FairRoot v18.6.x (similar fix done in FairRoot from v18.8.2 on)
Could also be deprecated if the handling is improved on the ROOT side, but timescale of our Fairsoft/Root transitions typicaly even longer than our FairRoot transitions

added BugFix Geometry mCBM labels

requested review from @f.uhlig

assigned to @f.uhlig

added 1 commit

• c2a1efea - StsSetup: replace BBox recompute fct w/ one proposed by ROOT expert, #2620

Compare with previous version

changed the description

Dear @v.friese, @f.uhlig,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 18 commits

• c2a1efea...eda85638 - 16 commits from branch computing:master
• 9b5ca303 - Externals: Add build time folder for bba to git ignores
• da89f41c - StsSetup: replace BBox recompute fct w/ one proposed by ROOT expert, #2620

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for da89f41c succeeds

merged