Skip to content
Snippets Groups Projects

WIP: Upgrades Rich

Closed Eoin Clerkin requested to merge e.clerkin/cbmroot:upgrade_rich into master

Reintroduces upgraded rich geometry.

Merge request reports

Checking pipeline status.

Closed by Eoin ClerkinEoin Clerkin 1 year ago (Apr 26, 2023 5:10pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eoin Clerkin added 1 commit

    added 1 commit

    Compare with previous version

  • Dear @f.uhlig, @c.muentz, @m.deveaux, @p.-a.loizeau,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • Author Developer

    Tested with rich_v22b -> without shield

    Fails Test: c2f_transport_sis100_electron (Failed) for

    CbmRoot_Merge_macosx_1015 CbmRoot_Merge_macosx_11_nov22p1 CbmRoot_Merge_macosx_11 CbmRoot_Merge_Singularity_debian11_apr21

    with error

    ==================================================================
    
    ### Run 0 start.
    [INFO] UnigenGenerator: Event ID 1, particles 963, primaries 963, b = 0 fm, phi (source) = 0 rad , phi (generated) = -0 rad
    >>> Event 0
    
     *** Break *** segmentation violation
    [/usr/lib/system/libsystem_platform.dylib] _sigtramp (no debug info)
    [] (no debug info)
    [/opt/fairsoft/apr21p2/lib/libGeom.6.22.08.so] TGeoShapeAssembly::DistFromOutside(double const*, double const*, int, double, double*) const /opt/fairsoft/source/apr21p2/build/Source/root/geom/geom/src/TGeoShapeAssembly.cxx:356
    [/opt/fairsoft/apr21p2/lib/libGeom.6.22.08.so] TGeoNavigator::FindNextDaughterBoundary(double*, double*, int&, bool) /opt/fairsoft/source/apr21p2/build/Source/root/geom/geom/src/TGeoNavigator.cxx:0
    [/opt/fairsoft/apr21p2/lib/libGeom.6.22.08.so] TGeoNavigator::FindNextBoundary(double, char const*, bool) /opt/fairsoft/source/apr21p2/build/Source/root/geom/geom/src/TGeoNavigator.cxx:847
    [/opt/fairsoft/apr21p2/lib/libg4root.dylib] TG4RootNavigator::ComputeStep(CLHEP::Hep3Vector const&, CLHEP::Hep3Vector const&, double, double&) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4processes.dylib] G4Transportation::AlongStepGetPhysicalInteractionLength(G4Track const&, double, double, double&, G4GPILSelection*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4tracking.dylib] G4SteppingManager::DefinePhysicalStepLength() (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4tracking.dylib] G4SteppingManager::Stepping() (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4tracking.dylib] G4TrackingManager::ProcessOneTrack(G4Track*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4event.dylib] G4EventManager::DoProcessing(G4Event*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4run.dylib] G4RunManager::ProcessOneEvent(int) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4run.dylib] G4RunManager::DoEventLoop(int, char const*, int) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libG4run.dylib] G4RunManager::BeamOn(int, char const*, int) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libgeant4vmc.dylib] TG4RunManager::ProcessRun(int) (no debug info)
    [/opt/fairroot/v18.6.7_apr21p2/lib/libBase.18.6.7.dylib] FairMCApplication::RunMC(int) (no debug info)
    [] (no debug info)
    [] (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::IncrementalExecutor::executeWrapper(llvm::StringRef, cling::Value*) const (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::Interpreter::RunFunction(clang::FunctionDecl const*, cling::Value*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::Interpreter::EvaluateInternal(std::__1::basic_string, std::__1::allocator > const&, cling::CompilationOptions, cling::Value*, cling::Transaction**, unsigned long) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::MetaSema::actOnxCommand(llvm::StringRef, llvm::StringRef, cling::Value*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::MetaParser::isXCommand(cling::MetaSema::ActionResult&, cling::Value*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::MetaParser::isCommand(cling::MetaSema::ActionResult&, cling::Value*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] cling::MetaProcessor::process(llvm::StringRef, cling::Interpreter::CompilationResult&, cling::Value*, bool) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] HandleInterpreterException(cling::MetaProcessor*, char const*, cling::Interpreter::CompilationResult&, cling::Value*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] TCling::ProcessLine(char const*, TInterpreter::EErrorCode*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCling.6.22.08.so] TCling::ProcessLineSynch(char const*, TInterpreter::EErrorCode*) (no debug info)
    [/opt/fairsoft/apr21p2/lib/libCore.6.22.08.so] TApplication::ExecuteFile(char const*, int*, bool) /opt/fairsoft/source/apr21p2/build/Source/root/core/base/src/TApplication.cxx:0
    [/opt/fairsoft/apr21p2/lib/libRint.6.22.08.so] TRint::ProcessLineNr(char const*, char const*, int*) /opt/fairsoft/source/apr21p2/build/Source/root/core/rint/src/TRint.cxx:763
    [/opt/fairsoft/apr21p2/lib/libRint.6.22.08.so] TRint::Run(bool) /opt/fairsoft/source/apr21p2/build/Source/root/core/rint/src/TRint.cxx:0
    [/opt/fairsoft/apr21p2/bin/root.exe] main /opt/fairsoft/source/apr21p2/build/Source/root/main/src/rmain.cxx:32
    [/usr/lib/system/libdyld.dylib] start (no debug info)
    WARNING - Attempt to delete the physical volume store while geometry closed !
    WARNING - Attempt to delete the logical volume store while geometry closed !
    WARNING - Attempt to delete the solid store while geometry closed !
    WARNING - Attempt to delete the region store while geometry closed !
    
  • Also failing in same function (but with shorter stack somehow):

  • Eoin Clerkin added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    When testing with Rich_v22b geometry, the same error occurs.

  • Author Developer

    There are small overlaps with rich_v22a and beam pipe has

     = Overlap ov00002: cave/pipe_v21i_0/conical_beam_pipe_1/conus_volume_1 overlapping cave/rich_v22a_0/rich_cont_1 ovlp=0.864891
    
  • Eoin Clerkin added 1 commit

    added 1 commit

    Compare with previous version

  • Eoin Clerkin added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    Running on local MacOS 11.4, run_tra_file.C fails with similar error roughly 2/3 of the time and successful completes roughly 1/3 of the time. Failure is always on 1st event.

  • Author Developer

    Following up tests, showed that fixing the random seed did not deterministically lead to failure or success. I could not prevent success by fixing the random seed to a failing one.

  • Author Developer

    Tests this morning showed, that if I comment out all detector subsystems other than rich_v22a and all passive volumes (platform,magnet,beampipe 1 and 2), I still get failures in similar proportion of time.

  • Author Developer

    The nodal structure of rich_v22a is rich_v22a->rich_v22a->rich_cont, I remove the unusual stucture. I run with random seed fixed equal 1 and only the rich detector and a target volume, the success failure rate appears different. Test shows roughly 2/3 successes.

  • Author Developer

    @s.lebedev Small internal overlap in the rich v22 geometries

    Info in : Number of illegal overlaps/extrusions : 1
    
    Unexpected Overlap:
     = Overlap ov00000: Volume belt: node belt2_1 overlapping belt4_1 ovlp=0.0178202
    
    Edited by Eoin Clerkin
  • This looks very strange. At the time of geometry creation there were no overlaps. All geometries were checked:

      gGeoManager->CloseGeometry();
      gGeoManager->CheckOverlaps(0.0001);
      gGeoManager->PrintOverlaps();
      gGeoManager->Test();

    See code here: https://git.cbm.gsi.de/computing/cbmroot/-/blob/master/sim/detectors/rich/geo/RichGeoCreator.cxx#L756

  • Eoin Clerkin added 1 commit

    added 1 commit

    • 9881cec3 - Reintroduces Rich_v22a for Linux

    Compare with previous version

  • Eoin Clerkin added 5 commits

    added 5 commits

    Compare with previous version

  • Eoin Clerkin added 1 commit

    added 1 commit

    • dbf3428b - Reintroduces Rich_v22a for Linux

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading