Skip to content
Snippets Groups Projects

Allow as input ROOT file from ZIP archives

Merged Florian Uhlig requested to merge f.uhlig/cbmroot:fix_cbmplutogenerator into master
All threads resolved!

Since the size of a single PLUTO file is very small the preferred storage solution for them is to store a large number of them in a archive. ROOT is able to handle ROOT files stored in a ZIP archive so the file handling in the class was adapted for the ZIP file usage.

Edited by Florian Uhlig

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florian Uhlig marked as a Work In Progress

    marked as a Work In Progress

  • Florian Uhlig added 4 commits

    added 4 commits

    Compare with previous version

  • Florian Uhlig added 1 commit

    added 1 commit

    • 7a0e88fa - Allow as input ROOT file from ZIP archives

    Compare with previous version

  • Florian Uhlig added 293 commits

    added 293 commits

    • 7a0e88fa...aad69a01 - 289 commits from branch computing:master
    • 98b88166 - Allow as input ROOT file from ZIP archives
    • 35c16a8f - Fix problem with generated dictionary
    • 95c99eec - Add function which checks if an input is a ROOT file
    • 693c962f - Use new function th check for ROOT file existence

    Compare with previous version

  • Florian Uhlig unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Florian Uhlig resolved all threads

    resolved all threads

  • Florian Uhlig added 10 commits

    added 10 commits

    • 693c962f...b132e5c0 - 6 commits from branch computing:master
    • fa140c49 - Allow as input ROOT file from ZIP archives
    • c592fc38 - Fix problem with generated dictionary
    • bf16a18d - Add function which checks if an input is a ROOT file
    • 9ace372b - Use new function th check for ROOT file existence

    Compare with previous version

  • Florian Uhlig added 5 commits

    added 5 commits

    • 159f6e36 - 1 commit from branch computing:master
    • 895ea394 - Allow as input ROOT file from ZIP archives
    • a55094f2 - Fix problem with generated dictionary
    • 1c2c120d - Add function which checks if an input is a ROOT file
    • 4a58052b - Use new function th check for ROOT file existence

    Compare with previous version

  • @v.friese, could you please check the MR again and merge it if okay.

  • Florian Uhlig added 8 commits

    added 8 commits

    • 4a58052b...507214c3 - 4 commits from branch computing:master
    • a233d11d - Allow as input ROOT file from ZIP archives
    • 6126a4c7 - Fix problem with generated dictionary
    • a60b03b3 - Add function which checks if an input is a ROOT file
    • 181267c9 - Use new function th check for ROOT file existence

    Compare with previous version

  • Florian Uhlig added 11 commits

    added 11 commits

    • 181267c9...7a049115 - 7 commits from branch computing:master
    • 74f75285 - Allow as input ROOT file from ZIP archives
    • 191c575c - Fix problem with generated dictionary
    • aa2dabfa - Add function which checks if an input is a ROOT file
    • 6207f3b7 - Use new function th check for ROOT file existence

    Compare with previous version

  • Florian Uhlig added 47 commits

    added 47 commits

    • 6207f3b7...83eaebdc - 44 commits from branch computing:master
    • 36b2f640 - Allow as input ROOT file from ZIP archives
    • 6e120c72 - Add function which checks if an input is a ROOT file
    • cc36b2d5 - Use new function th check for ROOT file existence

    Compare with previous version

  • Looks fine. Please re-format with our new style file and rebase.

    Btw: It would be a nice functionality if one could specify a zip file as input and in case there are several ROOT files archived within they are automatically used as a chain.

  • The feature with the chain should be easy to implement but I am not sure if this is a feature you really need. Probably you store in zip files input files like pluto decays of an omega which are rather small. When using the files normally you have one of these files per urqmd input file which you use without chaning them together.

    I have also some more features inside so in my opinion it would be good the check the type of the root file. With the current check you only know that you find the requested root file but you don't know the type of stored information (pluto, unigen, ...).

    I will reformat and rebase.

  • Florian Uhlig added 15 commits

    added 15 commits

    • cc36b2d5...d8cb9140 - 11 commits from branch computing:master
    • 8c4aaabb - Allow as input ROOT file from ZIP archives
    • 5cbe3713 - Add function which checks if an input is a ROOT file
    • 990a7fa4 - Use new function th check for ROOT file existence
    • d30f9bab - Apply clang format

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading