KF: fixes in KFParticleFinder according to the new TOF geometry

KF: fix TOF matching efficiency in KFParticleFinder according to:

• new tof geometry
• new target position
• 1000ns time shift in simulation

changed milestone to %FEB23

requested review from @v.friese

assigned to @se.gorbunov

added 1 commit

• 2ef45587 - KF: minor code format

Compare with previous version

added 1 commit

• 42f93c9d - KF: minor code format

Compare with previous version

@se.gorbunov,

do I get it right that there was no problem with the TOF matching itself but with the calculation of the efficiencies?

Dear @se.gorbunov, @v.akishina,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 8 commits

• 1fb1a27a - 1 commit from branch computing:master
• 39c9a569 - fixes in CbmKFTrackQa
• 3a3baea8 - add Sts->Tof matching efficiencies to CbmKFTrackQa task
• f884fe29 - get rid of the hardcoded target position in CbmKFParticleFinder
• 14960cf9 - get rid of the hardcoded event time in CbmKFParticleFinderPID
• 56df88b0 - update of the TOF cuts in CbmKFParticleFinderPID from I. Vassiliev
• 1c704a8b - KF: minor code format
• 0a08a9fd - KF: minor

Compare with previous version

changed title from KF: fix TOF matching efficiency in KFParticleFinder to KF: fixes in KFParticleFinder according to the new TOF geometry

@v.friese, as we discussed, I tried to read the event t0 properly - from CbmEvent instead of MCEventList.

Unfortunately, it didn't work out of the box. The LIT tracker currently doesn't work with the event builder. It only runs in an obsolete "event mode". We need to get rid of this "old event mode" everywhere, but it will take some time. Therefore I propose to merge the MR as it is now and switch from "event mode" to "event builder" mode in a separate MR.

@se.gorbunov Shall we leave that for this MR and make a better implementation of the TOF geometry access afterwards?

Hi Volker, I'd like to do it properly. I'm trying to fix this MR and i need some more time. The current problem is that CbmKFParticleFinderQa crashes when it runs with the event builder, I'm fixing it.

added 28 commits

• 0a08a9fd...f71635f8 - 22 commits from branch computing:master
• a0ce0ca1 - fixes in CbmKFTrackQa
• ef75a5ef - add Sts->Tof matching efficiencies to CbmKFTrackQa task
• 78611363 - get rid of the hardcoded target position in CbmKFParticleFinder
• 4ab685b0 - add CbmLink interfaces to CbmMCEventInfo and CbmMCEventList
• 0d148c32 - KF: make CbmKFParticleFinderQa run with new time-slice data types
• beca5a59 - KF: get rid of hardcoded event time in CbmKFParticleFinderPID and hardcoded cuts

Compare with previous version

resolved all threads

added 1 commit

• 11acbd7f - KF: cosmetic changes in CbmKFParticleFinderPID

Compare with previous version

@v.friese, I think, everything is fine now.

added 12 commits

• 11acbd7f...915af2f7 - 5 commits from branch computing:master
• 27147b88 - fixes in CbmKFTrackQa
• 17009d57 - add Sts->Tof matching efficiencies to CbmKFTrackQa task
• f564ef72 - get rid of the hardcoded target position in CbmKFParticleFinder
• 571b287c - add CbmLink interfaces to CbmMCEventInfo and CbmMCEventList
• e15bbe39 - KF: make CbmKFParticleFinderQa run with new time-slice data types
• 98ae4c94 - KF: get rid of hardcoded event time in CbmKFParticleFinderPID and hardcoded cuts
• 14c98d98 - KF: cosmetic changes in CbmKFParticleFinderPID

Compare with previous version