Support for CbmTzdDigi in unpacking, event builder and TOF reco.

added 5 commits

b3859bd4...6e12722f - 2 commits from branch computing:master
bacedc25 - Introduce BMON digitizer with a simple, parameterised implementation along...
2c9f0805 - Remove declaration of not implemenetd method. Refs #2630.
145b5b1b - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...

I think if we want to modify the existing mCBM unpacker used for real data, we will need to make the BMon digi class a copy of the TofDigi one or at least something with more than just the time:

it has at least a channel dimension (0 to 16) and may get a side or detector dimension end of next year(horizontal/vertical or detector 0/1), which may be used for clustering
it has a TOT (charge) field which is used for walk correction of the time

=> Maybe to include already in Volker MR, but I did not react there as this was beyond his goal of a short term fix for the simulations

@f.uhlig was also originally thinking of just "cloning" the current TOF digi as far as I know

added 7 commits

145b5b1b...5a0b86b0 - 3 commits from branch computing:master
919a70c1 - Introduce BMON digitizer with a simple, parameterised implementation along...
32ac4c3d - Remove declaration of not implemenetd method. Refs #2630.
a1d642e3 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
883845bf - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.

Compare with previous version

changed the description

changed title from WIP: Support for CbmBmonDigi in event builder. to WIP: Support for CbmTzdDigi in event builder.

changed the description

added 8 commits

9e78e152 - Introduce BMON digitizer with a simple, parameterised implementation along...
07d0ec0c - Remove declaration of not implemenetd method. Refs #2630.
8d4ef5b0 - Some cleanup
2806ae65 - Rename BMON to TZD in file names.
b90d1815 - Reflect the name change BMON to TZD in the simulation code.
2a89bb76 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
d7747642 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
6193b510 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.

Compare with previous version

@v.friese @f.uhlig @p.-a.loizeau

I just updated this MR to account for the recent nomenclature change (Bmon -> Tzd).

It was basically clear from yesterday's discussions, but I convinced myself of this once more, that a Tzd unpacker is needed before we can move forward any further here.

added 17 commits

6193b510...8a41c847 - 8 commits from branch computing:master
3bc899e6 - Introduce BMON digitizer with a simple, parameterised implementation along...
2574d7ee - Remove declaration of not implemenetd method. Refs #2630.
cf3620bb - Some cleanup
faaba7e6 - Rename BMON to TZD in file names.
d8cfcf04 - Reflect the name change BMON to TZD in the simulation code.
ba0ef908 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
9f1eecf0 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
2528e099 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
60fbd4c2 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

Updated event-time calculation to earliest Tzd digi instead of mean value.

added 15 commits

60fbd4c2...8adfa6a2 - 6 commits from branch computing:master
ba81e7e7 - Introduce BMON digitizer with a simple, parameterised implementation along...
8dceebea - Remove declaration of not implemenetd method. Refs #2630.
4a70497e - Some cleanup
c5343831 - Rename BMON to TZD in file names.
cb31319f - Reflect the name change BMON to TZD in the simulation code.
8d49c739 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
16f141d3 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
c3b7c6fe - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
a29573a4 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

@f.uhlig @v.friese After many rebasings the commit history is kind of weird, but the end result seems to come out right.

I think this will be cleaned up after I do an interactive rebase to move my unpacker commits to the front of the MR history

mentioned in merge request !1027 (merged)

added 12 commits

a29573a4...8d85a747 - 3 commits from branch computing:master
792db9a9 - Introduce BMON digitizer with a simple, parameterised implementation along...
00ed01b1 - Remove declaration of not implemenetd method. Refs #2630.
0738888f - Some cleanup
a40bdaca - Rename BMON to TZD in file names.
a2028405 - Reflect the name change BMON to TZD in the simulation code.
a92caf49 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
c71e19b6 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
cf9fca25 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
b813b45b - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

added 1 commit

b7f4147a - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

changed title from WIP: Support for CbmTzdDigi in event builder. to Support for CbmTzdDigi in event builder.

mentioned in merge request !962 (merged)

added 10 commits

d25b4751 - 1 commit from branch computing:master
2806ba64 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
e0622677 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
7d75a357 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
6206150a - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
36543825 - Fix preexisting bugs/features in RecoUnpackAlgo template
aa71024d - Add old-style TZD unpacker algo & config encapsulating the TOF algo
965fabe9 - Use the TZD unpacker instead of BMon one in Reco steering class
27cfe3f8 - Add usage of address field to TzdDigi
2bd11497 - switch unpack macro from BMON to TZD

Compare with previous version

marked this merge request as draft

added 9 commits

9c2d7dbc - Fix preexisting bugs/features in RecoUnpackAlgo template
b5223e8f - Add usage of address field to TzdDigi
752ecdd7 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
480ae43f - Use the TZD unpacker instead of BMon one in Reco steering class
87a6002b - switch unpack macro from BMON to TZD
b4edd949 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
fc5e3c19 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
cb4ab447 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
679cb565 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

added 7 commits

bb5bd169 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
a45d1420 - Use the TZD unpacker instead of BMon one in Reco steering class
257964fe - switch unpack macro from BMON to TZD
3a0ee661 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
c167cc4f - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
763b77f0 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
389aff6b - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

Dear @f.uhlig, @p.-a.loizeau, @v.friese, @n.herrmann, @i.deppner, @d.smith,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 9 commits

022c52a3 - Fix preexisting bugs/features in RecoUnpackAlgo template
5114a521 - Add usage of address field to TzdDigi
6748efb3 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
cb4f8cb2 - Use the TZD unpacker instead of BMon one in Reco steering class
ef71243d - switch unpack macro from BMON to TZD
899a6b71 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
722361ad - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
4e476334 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
da99a51c - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...

Compare with previous version

added 9 commits

991106b7 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
967ea752 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
157b0f94 - Use the TZD unpacker instead of BMon one in Reco steering class
7c583cf3 - switch unpack macro from BMON to TZD
602de869 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
3c8181e9 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
450e8e98 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
388ff7c6 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
1853db73 - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)

Compare with previous version

added 9 commits

ecca310d - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
20417990 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
57ff2ec4 - Use the TZD unpacker instead of BMon one in Reco steering class
174e8990 - switch unpack macro from BMON to TZD
74f97af0 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
8fb02fd5 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
1f11862c - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
09d8c849 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
ed19eb55 - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)

Compare with previous version

added 1 commit

cb43dcf6 - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.

Compare with previous version

added 13 commits

d0a9249d - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
2b9f7f82 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
c060bb77 - Use the TZD unpacker instead of BMon one in Reco steering class
189dc524 - switch unpack macro from BMON to TZD
100ab754 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
7ea55d41 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
7f18d409 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
81aca244 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
8385315e - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
3dff3864 - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
6e2c8201 - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
c621e516 - Switch DigiEvent from TOF to TZD digis for T0 + update online data lib <breaks 2 tasks!>
0efed07c - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device

Compare with previous version

added 13 commits

7aed7290 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
de251f77 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
58f626c4 - Use the TZD unpacker instead of BMon one in Reco steering class
7370785e - switch unpack macro from BMON to TZD
dc4cc87d - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
cc06b534 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
d30fb3bc - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
e47b2ec5 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
0b6fd50e - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
e2669c75 - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
4bdfbb63 - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
ae1a760d - Switch DigiEvent from TOF to TZD digis for T0 + update online data lib <breaks 2 tasks!>
25192c68 - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device

Compare with previous version

added Reconstruction mCBM labels

added 17 commits

25192c68...9321fa84 - 2 commits from branch computing:master
2d5b5bd4 - Fix preexisting bugs/features in RecoUnpackAlgo template
0930c3b6 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
fc7c9ed9 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
eec36654 - Use the TZD unpacker instead of BMon one in Reco steering class
e60c031e - switch unpack macro from BMON to TZD
72d93dfa - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
bcdcae6c - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
474dd972 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
11ff2f5a - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
74b6d36a - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
065534fb - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
f4ef9385 - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
bae459b6 - Switch DigiEvent from TOF to TZD digis for T0 + update online data lib <breaks 2 tasks!>
bcebd467 - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device
48009655 - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

added 1 commit

1c249f3d - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

added 1 commit

7f081a72 - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

added 17 commits

7f081a72...4cfdae6d - 2 commits from branch computing:master
51ccb5be - Fix preexisting bugs/features in RecoUnpackAlgo template
fdc17ec5 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
277c0625 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
3552a7b7 - Use the TZD unpacker instead of BMon one in Reco steering class
bd2f3223 - switch unpack macro from BMON to TZD
df2a44cb - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
f523b12b - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
3248c6b8 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
9d00dbb5 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
dab1782f - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
c4846f66 - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
26cb78e3 - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
219ed6dd - Switch DigiEvent from TOF to TZD digis for T0 + update online data lib <breaks 2 tasks!>
559b68f6 - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device
8ec8b0cd - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

changed title from Draft: Support for CbmTzdDigi in event builder. to Draft: Support for CbmTzdDigi in unpacking, event builder and TOF reco.

changed the description

added 38 commits

8ec8b0cd...7d79849f - 23 commits from branch computing:master
681fb04f - Fix preexisting bugs/features in RecoUnpackAlgo template
c0a61710 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
cf64328f - Add old-style TZD unpacker algo & config encapsulating the TOF algo
b6bfe9d5 - Use the TZD unpacker instead of BMon one in Reco steering class
bf1c0e36 - switch unpack macro from BMON to TZD
b5b4a7b6 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
d5644351 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
83f8de9b - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
161967c7 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
21897aa2 - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
0f5e9eca - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
17531762 - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
1a0543a5 - Switch DigiEvent/DigiData from TOF to TZD digis for T0 + fix online data lib <breaks 2 tasks!>
de599a0f - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device
b9226ea3 - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

added 14 commits

f6837020 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
34044fb1 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
08f6cdf9 - Use the TZD unpacker instead of BMon one in Reco steering class
1783885d - switch unpack macro from BMON to TZD
bc4600d1 - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
94a2e594 - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
29f473c0 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
36fea403 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
57cc9c0b - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
4c807234 - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
4e88b57a - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
235a2446 - Switch DigiEvent/DigiData from TOF to TZD digis for T0 + fix online data lib <breaks 2 tasks!>
2ac4c4fe - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device
04396b3e - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

added 14 commits

3b8e25c5 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
2e0435a0 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
202c6170 - Use the TZD unpacker instead of BMon one in Reco steering class
318621ed - switch unpack macro from BMON to TZD
43d206fb - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
3b5bcd3e - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
cc1e1199 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
98255be1 - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
8953cad7 - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
65912403 - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
951f3b96 - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
def6ca65 - Switch DigiEvent/DigiData from TOF to TZD digis for T0 + fix online data lib <breaks 2 tasks!>
ebb0cc7a - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device
2cb07bdf - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

With the latest version I added boost serialization versioning and a special boost deserialization for the old format of CbmDigiData.

Unclear however for me how to test it easily.
Could be that the easiest would be to craft a small macro creating a fake CbmDigiEvent with only T0 digis, run in with the current master, then try to load it with this branch. I may attempt this tomorrow if I find the time

added 14 commits

6c0d0ed8 - Prepare TOF and TZD digis for switch to TZD in unpack, event build and reco
db3a2445 - Add old-style TZD unpacker algo & config encapsulating the TOF algo
4548f336 - Use the TZD unpacker instead of BMon one in Reco steering class
910d6869 - switch unpack macro from BMON to TZD
253dd76f - Added support for new CbmBmonDigi class to CbmAlgoBuildRawEvents and...
65e15a7b - Added event time computation from Bmon digis to CbmAlgoBuildRawEvents.
7a7f1ae1 - Replaced CbmBmonDigi by CbmTzdDigi in CbmAlgoBuildRawEvents and related classes.
5b39d54b - Changed event-time computation from mean of Tzd digis to earliest Tzd digi in...
da36c206 - Convert TOF reco classes to TZD digi as T0 storage (instead of TOF)
8e08c69b - Updated CbmDeviceBuildDigiEvents and CbmDeviceBuildRawEvents to use CbmTzdDigi.
7264a07a - [MQ mcbm]: Switch to TZD unpacker and Digis in Unpack device
9e9f6ef4 - Switch DigiEvent/DigiData from TOF to TZD digis for T0 + fix online data lib <breaks 2 tasks!>
68c7cd74 - [MQ mcbm]: Switch to TZD Digis in DigiEventSink device
a3c89be0 - Updated CbmTaskBuildEvents, CbmTaskMakeRecoEvents and _GTestEventBuilder to support CbmTzdDigi.

Compare with previous version

resolved all threads

@d.smith, @p.-a.loizeau,

what is the status of this MR? I went through once and all my change requests were added. Could you please assign a reviewer and an assignee.

Support for CbmTzdDigi in unpacking, event builder and TOF reco.

Merge request reports

Activity