The usage of std::binary_function is really old legacy to define the functions
used in STL algorithms like std::sort. std::binary_function was deprecated with
C++11 and removed from C++ with C++17. Obviously it is still supported by some
compilers since compilation errors only occured with newer Apple clang versions.

Switch to the modern implementation using lambdas in the STL algorithms.
This also increase code readability since the code is located at the same place
where it is used.

The change was confirmed to not introduce changes in the output by comparing
the produced TTrees before and after the commit in all produced ROOT files.

[BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of NO_ROOT flag to libraries in reco folder

- Build AlgoOffline library only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
- Build [Ca/Kf]CoreOffline libs only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
- Use AlgoOffline as dep for libs CbmSimDigitizationSteer CbmAtConverterSteer CbmRecoOfflineSteer

cbm::algo::ca::TrackParamBase (and derivatives) are moved to the KfCore library (now, cbm::algo::kf::TrackParamBase)

Additionally, dependiencies are cleaned-up

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Martin Beyer authored 1 year ago and Volker Friese committed 1 year ago

Rich: Major digitizer rework using signal buffers, also implementing crosstalk and charged particle clusters

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

There were rich ring finders in the L1 code base which were compiled and linked
into libL1. With the change in the build system this results in a circular
dependency between the L1 and CbmRichReco libraries which was resolved by
removing the classes from compilation.
With this commit the classes are moved from the L1 code base into the rich
reconstruction code base.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.