Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Remove by hand added CbmTsEventHeader from CbmRecoUnpack. Instead, use the getter from the FairRun::Instance() to access the event header. Remark a fatal will be created if the wrong event header is set in the steering macro

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Add copy assignment operator definition for CbmTrdDigi

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Fix some warnings for Psd Rich and Tof algorithms

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Switch form info to log for debug log statement

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Changed severity for large amount of LOG statements

Changed default from info to debug for a larger amount of tof log messages. Otherwise, it makes info reading with all subsystems almost impossible.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Implemented empty variables for configs. Such that an if based add can be used for add to source and the part below "need not to be touched" also does not need to be touched to (de)activate configs.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

The emplace_back call was missing, which lead to the fact that no digis could be found.
- Remark time extraction to be checked by experts no correlations visible to the Trd in +- 1000 ns

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Had to include some directorie in the L1 CmakeList

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Unfortunately this does not yet produce digis, but I am note sure, if it is an parameter based issue or an issue with the implementation. I think it needs some experts from the Sts to have a look. Which is why I am pushing it.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Removed the setDerivedTsParameters empty function implementation. It is handled by the base template
To be reimplemented when needed.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

For the current situation with the TRD1D and TRD2D configs trying to create and access in principle the same "TrdDigi" branch a small workaround in the CbmRecoUnpack was required. Such that the first Config does not loose the correct pointer when the seconds overwrites the branch in the FairRootManager.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Seems to have similar issues with the includes like PSD.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Except for Psd the classes are empty dummies.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Since, we do not use the class name in our output branches I added a GetBranchName() function for all digis connected to the mcbm2021 beamtime. @todo add the function to other digis (much,mvd).

After the long standing problem with the external package AnalysisTree was
fixed the tests with the latest FairSoft/FairRoot versions are enabled.
Test on Debian 8, Debian 10 and CentOS 7.

This version fixes a long standing problem of AnalysisTree with
ROOT versions >= 6.20. The produced files couldn't be read anylonger.
The problems is discussed in detail at https://redmine.cbm.gsi.de/issues/2108