In case of two institutes in the copyright statement add both cities.
Add commiter if missing.

- FIX: collision of fMonitor declared on both CbmStsUnpackAlgoBase and CbmStsUnpackAlgo (was preventing monitor usage)
- Make Debug mode of STS unpack monitor easier to control in the run_unpack_tsa.C macro
- Main plot: Ratio of DIGI/RAW per FEB
- Main plots: Share taken by each ch in each FEB for RAW, DIGIS and DUPLI
- Main plot: Ratio of DIGI/RAW for each ch in each FEB
- Main plot: Ratio of DUPLI/RAW for each ch in each FEB
- Debug plot: ADC of DUPLI for each ch in each FEB
- Debug plots: Evolution of Share taken by each ch in each FEB for RAW, DIGIS and DUPLI
- Debug plot: Evolution of Ratio of DIGI/RAW for each ch in each FEB
- Debug plot: Evolution of Ratio of DUPLI/RAW for each ch in each FEB
- FIX: Warnings in some printout

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

Bug 2: In both Legacy and current unpackers, a signed integer was used at some point to store/return the raw timestamp in clock cycles.
While the last bit would probably never be reached in standard usage, it could lead to negative values and crazy results during the
conversion through double (full precision time in ns) and back to unsigned integer (ns precision time) for data coming from badly
synchronized setups

Bug 3: In the current unpacker, the subtraction of the Timeslice start time from the TS_MSB value was not protected against the case of
badly synchronized data where the TS_MSb does not match the Timeslice index. It now triggers a Fatal as these data are not recoverable
with this unpacker.

Pierre-Alain Loizeau authored 3 years ago and Florian Uhlig committed 3 years ago

Bug 1: Size was too small which led to some digis with TS_MSB above 65555 escaping the duplicates filter.
No effect on the digi themselves (time is computed from the original 64b/32b value).

In the legacy case we can stay with 32b (instead of the original 64b or the old 16b) as the field in the
raw message is 29b, while in the current version we need 64b to account for potential TS_MSB cycles and
large Timeslice start offset.

Alexandru Bercuci authored 3 years ago and Florian Uhlig committed 3 years ago

protect against missing par files
update steering macro for the new TRD-2D interface
incorporate parameter calibration into the FASP read-out data
protect the code for the case of par un-consistency (found e.g. for TRD-2Dh)
add user interface to the Asic param set
rename modules in the TRD setup
extend the TRD module type index above one digit
adding class definition to allow SPADIC info generation during unpacking

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The wrong license headers currently block the merging of !470.

Dominik Smith authored 3 years ago and Florian Uhlig committed 3 years ago

Moved CbmStsDigitizeQa, CbmStsDigitizeQaReport and CbmStsFindTracksQa to qa subfolders. Updated CMakeLists.txt accordingly.

Pierre-Alain Loizeau authored 3 years ago and Volker Friese committed 3 years ago

- Add Binning FW support to the Print method of the StsXyterMessage, enabled by default
- Fix the duplicate digis filtering in the STS unpacker and make it flag controllable
- Add an optional full time sorting to the Unpackers steering class
- Related mCBM macros changes

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Dominik Smith authored 3 years ago and Dominik Smith committed 3 years ago

Implemented monitoring for CbmStsUnpackAlgoLegacy. Minor fix to CbmStsUnpackConfig and some cleanup of CbmStsUnpackAlgo and CbmStsUnpackAlgoBase.

Adrian A. Weber authored 3 years ago and Volker Friese committed 3 years ago

remove sorting from Algo and add check if time is greater 0. Mkissing backplanes in data could produce negative values and bee an issue. These digis are not stored

This adds a safeties that protect from unwanted behavior, in case of corrupted EOM messages.

These compiler warnings are only seen with clang on macosx.
Fix format in printf and Form functions.
Comment unused parameters.
Use correct C++ version when building the external flesnet project.

Set axes of several histograms to adaptive and adjusted ranges to account for new timing convention.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

In the data from mcbm2021 the possibility that the bits of the number of samples indicator in EOMs can be corrupted. This commit implements a safety which prevents the unpacker to go into a broken state in case of corrupted bits.

Pascal Raisig authored 3 years ago and Florian Uhlig committed 3 years ago

This commit adds the measurement of the cpu and wall time to the unpacking algo template/CbmRecoUnpack::unpack function.
The values are printed add the end of the run and stored additionally in an output histogram.

Adrian A. Weber authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

add mRICH time offset correction and add masking of DiRICH boards to avoid the error messages. Error messages tells you now, which board has a problem.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Fix some warnings for Psd Rich and Tof algorithms

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Switch form info to log for debug log statement

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Changed severity for large amount of LOG statements

Changed default from info to debug for a larger amount of tof log messages. Otherwise, it makes info reading with all subsystems almost impossible.

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

The emplace_back call was missing, which lead to the fact that no digis could be found.
- Remark time extraction to be checked by experts no correlations visible to the Trd in +- 1000 ns

Pascal Raisig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Had to include some directorie in the L1 CmakeList