Alexandru Bercuci authored 1 year ago and Florian Uhlig committed 1 year ago

Move macro code from Create_geometry_* macro to namespace cbm::trd:geo.
Implement the latest modifications to the design of the chamber and FEB as they are proposed for day 1.

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Lena Rossel authored 1 year ago and Florian Uhlig committed 1 year ago

Add missing break statements (Dennis Spicker)

Without these break statements,
the resulting gamma would always be
the one for the highest Bethe-Bloch value.

Fix calculation of gamma (Lena Rossel)

Change speed of light to 1.
Momentum and mass are given in GeV, therefore speed of light does not need to be c=3e8.

(CbmTrdParModAsic) and the proper set related. Add also CROB id to the
param file

The function sprintf is marked deprecated with the latest Clang version.
Move from sprintf to snprintf. Define and use buffer size.
Check the return value in a function where this is important.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Alexandru Bercuci authored 2 years ago and Sergey Gorbunov committed 2 years ago

analysing FASP frame

Alexandru Bercuci authored 2 years ago and Sergey Gorbunov committed 2 years ago

(EbyE/TB)

Alexandru Bercuci authored 2 years ago and Sergey Gorbunov committed 2 years ago

definition. Use data from mCBM22 to calibrate against ToF simulations
for both EbyE and TB modes

Alexandru Bercuci authored 2 years ago and Sergey Gorbunov committed 2 years ago

1. smeared MC point when generating PRF
2. add noise on FASP signal according to calibration (mean value, o
dependence on the actual FASP)

Since, the radiator is touched within the MR, we exchange its member appearances as raw pointer with smared shared pointers.
For backward compatibility with quite some amount of macros (quite some of them seem to be obsolete) forwarding constructors of CbmTrdDigitizer and CbmTrdQa have been implemented.

geometry

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

From FairRoot version v18.4.0 on the function CheckIfSensitive() of the class
FairModule is deprecated and replaced by the function IsSensitive(). The old
function is still available but usage results is a compilation error.
To be able to use FairRoot v18.2.1 and newer versions both functions are
implemented in the CbmRoot code where the old function simply forwards to the
new one. If there is no need to support older FairRoot versions the old
function can be simply removed from the source code.

Pascal Raisig authored 3 years ago and Volker Friese committed 3 years ago

Integration of TRD unpacking, with empty implementations for unpacker, monitor container and parameter container.

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.