The function sprintf is marked deprecated with the latest Clang version.
Move from sprintf to snprintf. Define and use buffer size.
Check the return value in a function where this is important.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add missing library dependencies and link directories.
Remove obsolete library dependencies and include/link directories.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

The code was copied at some time from an external project into the lx
directory. Since it fails the license header check the code was moved
to the externals directory. Also a second copy of the headers were deleted.

Sergey Gorbunov authored 3 years ago and Volker Friese committed 3 years ago

remove resets of the random seed from the compiled code. We should keep the ability to reproduce all the results when a non-zero seed is set in the main macro

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes

The latest version of our formating rules is applied to all header and source
files as well as to the macros using clang-format 11.0.

The class FairLogger is  meanwhile only a wrapper around the Logger class,
so use the Logger directly. This also helps to reduce many warnings when
using the Eclipse IDE.

Remove check for ZeroMQ.
ZeroMQ isn't needed any longer.

Fix installation of externals when using Spack.
Pass extra flags flags to NicaFemto configuration if needed.
Patch ipc source code. Add missing include file.
Cleanup .gitignore in externals.

Fix linking of CbmGlobalTraking library.
Add missing link directory. In normal installation Vc probably was found in the
ROOT installation. With Spack ROOT is build without builtin Vc.

Use correct syntax for function call.
With the latest FairMQ version the old backward compatibility layer was
removed. Use now the new syntax to change the state.

Administrator authored 4 years ago and Florian Uhlig committed 4 years ago

On macosx one needs a openmp installation which does not come with the system,
at least the omp.h header file is missing. brew has a package libomp which
installs the header and a library. Both are found by the cmake module
FindOpenMP and properly used during the compilation and linking.
In themoment there is still a runtime error when executing the L1 tracking
with OpenMP support on macosx, so switch off OpenMP for the time being.
The problem is investigated already. refs #2028.

Cleanup OpenMP handling in the build system. Move check for OpenMP to top
level. Remove OpenMP usage from all libs were it is not needed.

Unused parameters.
multi-line comments.

Apply code formatting to all source/header files and root macros.

Remove the ecal directory and the directory with the ecal data classes.
Adapt the build system accordingly. Closes #1756 @0.5h

This version is an exact copy of the last revision of the trunk branch
of the old SVN repository of CbmRoor at
https://subversion.gsi.de/cbmsoft/cbmroot/trunk
The old SVN repository will still be available for read access.