Administrator authored 1 year ago and Florian Uhlig committed 1 year ago

Remove commented code.
Move library dependency from public to private.

Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Add build system files for new mvd code structure
Move code from mvd directory to core/detectors/mvd, sim/detectors/mvd,
reco/detectors/mvd and analysis/detectors/mvd.
Create the libraries CbmMvdCore, CbmMvdSim, CbmMvdReco and CbmMvdAna.

This commit will not compile.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

With the change to the CMake targets the dependency tree was broken. The
generation of the ROOT dictionary is now a target on its own which did not
depend on anything except the header files needed for the specific library.
Some of these header files include other header files from the external
libraries. The problem was that now it became possible that the dictionary
generation started before the external header files were available.

Add explicit dependencies from these dictionaries to the external libraries.

Files moved to NO_DICT_SRC:
L1Algo/L1Event.cxx
L1Algo/L1EventMatch.cxx

Files are commented for time being in L1 target:
OffLineInterface/CbmL1RichENNRingFinder.cxx
OffLineInterface/CbmL1RichENNRingFinderParallel.cxx

xpu git tag version modified
Vc package finding moved to top level CMakeLists.txt

Administrator authored 2 years ago and Sergey Gorbunov committed 2 years ago

The C function to check if a number is finite is 'isfinite()'. Obviously the
'finite()' function is from C89 and was deprecated with C99 but not yet
removed. At least with the default compiler on macosx 12.5 (arm64) the function
was removed so we switch to 'isfinite()'.

reconstruction macros global updates: CbmL1 and CbmKF (as a FairRoot task) now need the interfaces to the tracking detectors. The interfaces are initialized in an additional task - CbmTrackingDetectorInterfaceInit, which should be added before. Please, refer to '$VMCWORKDIR/macro/run/run_reco.C' as an example

L1: tracking interfaces: the interface classes were moved to the '$VMCWORKDIR/core/detector/' directory

The KF and L1 packages set special compiler flags. Some of the warnings are
not present when using Clang such that a CMake check was implemented which
test the existense of those. The check simply compiles some C++ code with the
compiler flag added to the compile command. Unfortunately Clang only prints a
warning when a warning flag doesn't exist but successfuly finishes the
compilation such that the check suceeds. This results in many warnings during
compilation of L1.