Administrator authored 2 years ago and Florian Uhlig committed 1 year ago

Comment set but unused variables in much code.

The function sprintf is marked deprecated with the latest Clang version.
Move from sprintf to snprintf. Define and use buffer size.
Check the return value in a function where this is important.

Remove a special linker setting for macosx which isn't needed any longer.
With the build system changes the full list of dependecies is available at
link time.
Add a missing library dependency.

Use the same target names as provided by FairRoot with version v18.8.

Add the new target FairRoot::Online which is a new library conatining the
online related code which was previously part of the Base library.
In case of older FairRoot versions the target is only an alias for the target
FairRoot::Base such that the same dependencies already work with FairRoot
v18.6 which is our current default version.

Add the new target FairRoot::Online in all CMakeLists.txt where it is needed.

The FindFairRoot macro is also used when compiling NicaFemto. Since there is a
problem with the target definitions in NicaFemto the targets are not defined
when compiling NicaFemto.

needed on GCC 12 (Fedora 36)

Administrator authored 2 years ago and Pierre-Alain Loizeau committed 2 years ago

Remove obsolete, unneeded and unused code.

Jan de Cuveland authored 2 years ago and Administrator committed 2 years ago

- fles_ipc -> external::fles_ipc
- fles_logging -> external::fles_logging
- IPC_INCLUDE_DIRECTORY -> FLES_IPC_INCLUDE_DIRECTORY

Fix deprecation warnings about upercase log levels. Use lowercase ones.

Add missing license headers.
Small corrections of years, authors or copyright.

Remove wrong license header drom several files which came in by using a
template. The code was developed by the respective persons, the license header
came in by using a skeleton.

These compiler warnings are only seen with clang on macosx.
Fix format in printf and Form functions.
Comment unused parameters.
Use correct C++ version when building the external flesnet project.

Bug fix: Added missing break statement to loops in CbmAlgoBuildRawEvents::SetReferenceDetector() and CbmMcbm2019TimeWinEventBuilderAlgo::SetReferenceDetector().

Pierre-Alain Loizeau authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Changed severity for large amount of LOG statements

Changed default from info to debug for a larger amount of tof log messages. Otherwise, it makes info reading with all subsystems almost impossible.

correction in digi building to fix loss of major part of digis in vector as well as the inclusion of the reference time Stamp for each TS.