Frederic Julian Linz authored 1 year ago and Florian Uhlig committed 1 year ago

In the log file, there is now a colored printout for each step (tra, digi, reco, AT) if the step was successful or not.
If a step fails, the script is exited such that the CI can fail now and possible problems can be spot on each new MR directly

=> Also change geo setups check to be executed by CMAKE in geometry install step (also if already downloaded)
=> This is needed as the new way relies on the geometry git copy being already present

When sampling overlaps are less than predefined amount, then
ignore for test success/failure purposes. Combine arguments
for flag and sampling size. Rename and comments. Clang format.

- Make overlap threshold optional input parameter (default = 0.0001 as before)
- Make sampling controllable by flag (disabled by default)
- Make number of samples in sampling mode controllable by input par (default = 0 leading to ROOT default of 1M)

Two problems from ROOT side lead to it being unrelyable for now
- Threshold is not working in this method
- Changing the number of samples lead to really small overlaps apearing and disappearing

See https://github.com/root-project/root/issues/14675 for reference

Two problems from ROOT side lead to it being unrelyable for now
- Threshold is not working in this method
- Changing the number of samples lead to really small overlaps apearing and disappearing

See https://github.com/root-project/root/issues/14675 for reference

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Increase the number of sampling points to 2M