Add protections when tracking and/or track matching delivers strange results.

Frederic Julian Linz authored 1 year ago and Florian Uhlig committed 1 year ago

This MR introduced minor updates to the cbmreco_offline and cbm_atconverter binary: 
- colored log ouput 
- forward declaration of classes in header files 
- new function to get cbmsim tree from file 
- use consistently "firstTs" and "numTS" to set start event and number of processed events, respectively -STS track matching

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Oleksii Lubynets authored 1 year ago and Florian Uhlig committed 1 year ago

MC-true pdg code field was removed from VtxTracks branch long back in time.
This information is available via AT::Matching. 
The commented piece of code and empty (filled with zeros) field mc_pdg still remained
which was fixed with this MR.

Frederic Julian Linz authored 2 years ago and Florian Uhlig committed 2 years ago

Check cbm_header init before using it.
Added runtime error for MCEventList.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

With the change to the CMake targets the dependency tree was broken. The
generation of the ROOT dictionary is now a target on its own which did not
depend on anything except the header files needed for the specific library.
Some of these header files include other header files from the external
libraries. The problem was that now it became possible that the dictionary
generation started before the external header files were available.

Add explicit dependencies from these dictionaries to the external libraries.

Omveer Singh authored 2 years ago and Florian Uhlig committed 2 years ago

    CMakeList.txt files are modified according to modern CMake.
    generate_cbm_library() macro is used to make target.
    Imported targets of each package are used as dependencies.

When compiling one of the test macros the compilation crashed. The reson was
a problem with the generated dictionary. The problem could be solved by
removing an include statement from the header file.

Warnings from included header files which are outside of the scope of our code
base are not interesting when building CbmRoot. Definde those external include
directories as system include directories such that the compiler hide those
warnings automatically.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.

Administrator authored 3 years ago and Florian Uhlig committed 3 years ago

Add missing library dependencies and link directories.
Remove obsolete library dependencies and include/link directories.

Florian Uhlig authored 3 years ago and Pierre-Alain Loizeau committed 3 years ago

Somehow (at least on some systems) the link order was such that the
first directory was $SIMPATH/lib. This was even the case when the order was
defined differently in the CMakeLists.txt. The problem isn't yet understood
completely.

This results in the problem that libVc.a was taken from $SIMPATH/lib
were it is installed by ROOT/FairSoft. As long as the version provided with
CbmRoot and the version provided by ROOT were the same the problem wasn't
seen. When updating our internal Vc version this results in a creash when
loading libryries due to a version mismatch between the library version and
the header file version.

Unify user names in the license header authors list.
Remove duplicate users in the authors list.
Cleanupo of some other inor issues.

Decision to not use doxygen for licence headers. Removes doxygen formatting and file tag.

Pulls some author and date information from previous headers, adds this to information from the svn and git repositories.
Inlude the standard copyright header to approximately 2000 files with institute of original committer as copyright holder.
Contributing authors from previous declaration and repository records.

Files with detected previous copyright or authorship skipped.
Copyright claimed for the current or last CBMC institute of the original commiter to the SVN or GIT repositories.
File distributed under GNU public license version 3.0 declared.

Revert "Adds license header to .cxx, .cpp, .h, and .C files"

This reverts commit 94da1500.

Removes one blank line

Revert "Removes one blank line"

This reverts commit a8e5e236.

Preemptive empty lines removal

If first two lines of a file are empty, or have spaces and tabs only then remove the lines.

Revert "Preemptive empty lines removal"

This reverts commit da38bf5d.

Add empty line

For stylistic reasons, an empty line is added after doxygen header.

Revert "Add empty line"

This reverts commit 30491934.

Puts space between includes.

Revert "Puts space between includes."

This reverts commit 468b7024.

Add multiple authors tag

Lists authors in order of their contribution

Revert "Add multiple authors tag"

This reverts commit f5d3e748.

Removes empty line on one file for clang format compliance.

Revert "Removes empty line on one file for clang format compliance."

This reverts commit fbac8bad.

Small changes as per requested.

Add small (o) to original commiters username.

Adds running 10 percent instead of line count treshold for contributors.

Revert "Small changes as per requested."

This reverts commit 84af7b5f.

Long form of names

Word originator beside original committer of file.

Revert "Long form of names"

This reverts commit 759426e2.

Add space between comma seperated double affilliation institutes