[BugFix] Add [KfCore/CaCore/Algo]Offline libraries to remove feed down of NO_ROOT flag to libraries in reco folder

- Build AlgoOffline library only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
- Build [Ca/Kf]CoreOffline libs only if not in CBM_ONLINE_STANDALONE (aka not online container mode)
- Use AlgoOffline as dep for libs CbmSimDigitizationSteer CbmAtConverterSteer CbmRecoOfflineSteer

Radim Dvorak authored 1 year ago and Florian Uhlig committed 1 year ago

The current implementation works only for event-by-event based digitisation and reconstruction. When running time based the results will be definitely wrong.

Closes #3195

Add protections when tracking and/or track matching delivers strange results.

Frederic Julian Linz authored 1 year ago and Florian Uhlig committed 1 year ago

This MR introduced minor updates to the cbmreco_offline and cbm_atconverter binary: 
- colored log ouput 
- forward declaration of classes in header files 
- new function to get cbmsim tree from file 
- use consistently "firstTs" and "numTS" to set start event and number of processed events, respectively -STS track matching

Eoin Clerkin authored 1 year ago and Pierre-Alain Loizeau committed 1 year ago

Updates T0 digi classes with Bmon exquivalents. Standardises
the use of Bmon across code base and, in-use and legacy macros.

Oleksii Lubynets authored 1 year ago and Florian Uhlig committed 1 year ago

MC-true pdg code field was removed from VtxTracks branch long back in time.
This information is available via AT::Matching. 
The commented piece of code and empty (filled with zeros) field mc_pdg still remained
which was fixed with this MR.

Frederic Julian Linz authored 2 years ago and Florian Uhlig committed 2 years ago

Check cbm_header init before using it.
Added runtime error for MCEventList.

Add missing include statements and forward declarations.
In FairRoot a serious cleanup of include statements was done which needs fixes
in our code base.

Administrator authored 2 years ago and Florian Uhlig committed 2 years ago

With the change to the CMake targets the dependency tree was broken. The
generation of the ROOT dictionary is now a target on its own which did not
depend on anything except the header files needed for the specific library.
Some of these header files include other header files from the external
libraries. The problem was that now it became possible that the dictionary
generation started before the external header files were available.

Add explicit dependencies from these dictionaries to the external libraries.

Omveer Singh authored 2 years ago and Florian Uhlig committed 2 years ago

    CMakeList.txt files are modified according to modern CMake.
    generate_cbm_library() macro is used to make target.
    Imported targets of each package are used as dependencies.

When compiling one of the test macros the compilation crashed. The reson was
a problem with the generated dictionary. The problem could be solved by
removing an include statement from the header file.

Warnings from included header files which are outside of the scope of our code
base are not interesting when building CbmRoot. Definde those external include
directories as system include directories such that the compiler hide those
warnings automatically.

Use struct instead of class for forward declarations if the object is defined
as struct.
Remove unused data members, variables and parameters.
Remove an explicite usage of std::move to allow copy ellision.
Correct type in printf statements.
Add missing virtual destructor in some class.
Fix two issues where closing braces were at the wrong place.